From: James Prestwood <prestwoj@gmail.com>
To: "iwd@lists.linux.dev" <iwd@lists.linux.dev>
Cc: James Prestwood <prestwoj@gmail.com>,
Marcel Holtmann <marcel@holtmann.org>,
Denis Kenzior <denkenz@gmail.com>, KeithG <ys3al35l@gmail.com>
Subject: Re: [PATCH] build: Create ell directory for ell/ell.h target
Date: Tue, 14 May 2024 05:25:50 -0700 [thread overview]
Message-ID: <ce68de5c-bd18-463e-bd1d-7ab1ea300944@gmail.com> (raw)
In-Reply-To: <20240229195654.1579749-1-prestwoj@gmail.com>
Hi,
On 2/29/24 11:56 AM, James Prestwood wrote:
> Both ell/shared and ell/internal targets first create the ell/
> directory within IWD. This apparently was just luck that one of
> these always finished first in parallel builds. On my system at
> least when building using dpkg-buildpackage IWD fails to build
> due to the ell/ directory missing. From the logs it appears that
> both the shared/internal targets were started but didn't complete
> (or at least create the directory) before the ell/ell.h target:
>
> make[1]: Entering directory '/home/jprestwood/tmp/iwd'
> /usr/bin/mkdir -p ell
> /usr/bin/mkdir -p ell
> echo -n > ell/ell.h
> /usr/bin/mkdir -p src
> /bin/bash: line 1: ell/ell.h: No such file or directory
> make[1]: *** [Makefile:4028: ell/ell.h] Error 1
>
> Creating the ell/ directory within the ell/ell.h target solve
> the issue. For reference this is the configure command dpkg
> is using:
>
> ./configure --build=x86_64-linux-gnu \
> --prefix=/usr \
> --includedir=/usr/include \
> --mandir=/usr/share/man \
> --infodir=/usr/share/info \
> --sysconfdir=/etc \
> --localstatedir=/var \
> --disable-option-checking \
> --disable-silent-rules \
> --libdir=/usr/lib/x86_64-linux-gnu \
> --runstatedir=/run \
> --disable-maintainer-mode \
> --disable-dependency-tracking \
> --enable-tools \
> --enable-dbus-policy
> ---
> Makefile.am | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Makefile.am b/Makefile.am
> index 5ed6ab37..be287572 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -710,6 +710,7 @@ ell/internal: Makefile
> done > $@
>
> ell/ell.h: Makefile
> + $(AM_V_at)$(MKDIR_P) ell
> $(AM_V_at)echo -n > $@
> $(AM_V_GEN)for f in $(ell_headers) ; do \
> echo "#include <$$f>" >> $@ ; \
I noticed this patch was still in my private IWD tree and never got
merged. Could we take a look at this? For me (and Keith) it appears to
be required for debian builds. For whatever reason that build system
triggers the timing just right that the ell/ directory doesn't exist
when copying the ell source.
Thanks,
James
next prev parent reply other threads:[~2024-05-14 12:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-29 19:56 [PATCH] build: Create ell directory for ell/ell.h target James Prestwood
2024-03-01 15:00 ` KeithG
2024-05-14 12:25 ` James Prestwood [this message]
2024-05-14 15:25 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce68de5c-bd18-463e-bd1d-7ab1ea300944@gmail.com \
--to=prestwoj@gmail.com \
--cc=denkenz@gmail.com \
--cc=iwd@lists.linux.dev \
--cc=marcel@holtmann.org \
--cc=ys3al35l@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).