From: Denis Kenzior <denkenz@gmail.com>
To: James Prestwood <prestwoj@gmail.com>, iwd@lists.linux.dev
Subject: Re: [PATCH 3/8] station: add handling for new NETCONFIG state
Date: Thu, 4 Jan 2024 15:01:26 -0600 [thread overview]
Message-ID: <e0b3f24a-e95b-4b9c-bcdb-2d2f96ff2f99@gmail.com> (raw)
In-Reply-To: <27188916-f1b9-4476-ab58-05d27d361820@gmail.com>
Hi James,
>> Hence why I think it is better to treat this as an initial connection failure
>> rather than pretending that we roamed and dealing with the consequences.
> So when I originally sent the netconfig after roam change I wanted to actually
> prevent any roaming until netconfig finished, but instead we allowed the roam
> and restarted netconfig. So yes, I feel like this wasn't the right direction to
> go. I'm thinking instead we should prevent any roaming, cap the netconfig time
> (e.g. 15 seconds) and fail the connection if netconfig doesn't finish. Then we
Preventing roaming would certainly be easier to implement, but the fact that you
had roams during the initial connection (the original problem which prompted
this change), probably means that we do want to allow roaming eventually.
6G in particular would benefit, since attaching to 2.4/5GHz frequencies first,
then asking for neighbor reports and roaming to 6G is probably the best strategy
compared to passively scanning on the 6 GHz band.
Regards,
-Denis
next prev parent reply other threads:[~2024-01-04 21:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-03 18:46 [PATCH 1/8] station: handle netconfig after roaming for FW roams James Prestwood
2024-01-03 18:46 ` [PATCH 2/8] station: add additional internal state, STATION_STATE_NETCONFIG James Prestwood
2024-01-03 18:46 ` [PATCH 3/8] station: add handling for new NETCONFIG state James Prestwood
2024-01-04 18:14 ` Denis Kenzior
2024-01-04 18:31 ` James Prestwood
2024-01-04 18:55 ` Denis Kenzior
2024-01-04 19:55 ` James Prestwood
2024-01-04 21:01 ` Denis Kenzior [this message]
2024-01-03 18:46 ` [PATCH 4/8] station: add debug events for internal states James Prestwood
2024-01-04 17:57 ` Denis Kenzior
2024-01-03 18:46 ` [PATCH 5/8] auto-t: update roam test to use new debug events James Prestwood
2024-01-04 17:58 ` Denis Kenzior
2024-01-03 18:46 ` [PATCH 6/8] auto-t: add test for roaming + netconfig James Prestwood
2024-01-03 18:46 ` [PATCH 7/8] auto-t: improve failure handling in testPSK-roam James Prestwood
2024-01-04 18:00 ` Denis Kenzior
2024-01-03 18:46 ` [PATCH 8/8] auto-t: fix random testPSK-roam failure James Prestwood
2024-01-04 18:00 ` Denis Kenzior
2024-01-04 17:56 ` [PATCH 1/8] station: handle netconfig after roaming for FW roams Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0b3f24a-e95b-4b9c-bcdb-2d2f96ff2f99@gmail.com \
--to=denkenz@gmail.com \
--cc=iwd@lists.linux.dev \
--cc=prestwoj@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).