From: Denis Kenzior <denkenz@gmail.com>
To: James Prestwood <prestwoj@gmail.com>, iwd@lists.linux.dev
Subject: Re: [PATCH] scan: remove unneeded debug prints
Date: Mon, 7 Aug 2023 23:59:44 -0500 [thread overview]
Message-ID: <e0de1abc-ca37-62d9-92bf-6a460eb63d5e@gmail.com> (raw)
In-Reply-To: <20230807191207.442919-1-prestwoj@gmail.com>
Hi James,
On 8/7/23 14:12, James Prestwood wrote:
> Removed several debug prints which are very verbose and provide
> little to no important information.
>
> The get_scan_{done,callback} prints are pointless since all the
> parsed scan results are printed by station anyways.
>
> Printing the BSS load is also not that useful since it doesn't
> include the BSSID. If anything the BSS load should be included
> when station prints out each individual BSS (along with frequency,
> rank, etc).
>
> The advertisement protocol print was just just left in there by
> accident when debugging, and also provides basically no useful
> information.
> ---
> src/scan.c | 8 --------
> 1 file changed, 8 deletions(-)
>
Applied, thanks.
Regards,
-Denis
prev parent reply other threads:[~2023-08-08 4:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-07 19:12 [PATCH] scan: remove unneeded debug prints James Prestwood
2023-08-08 4:59 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0de1abc-ca37-62d9-92bf-6a460eb63d5e@gmail.com \
--to=denkenz@gmail.com \
--cc=iwd@lists.linux.dev \
--cc=prestwoj@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).