From: James Prestwood <prestwoj@gmail.com>
To: Denis Kenzior <denkenz@gmail.com>, iwd@lists.linux.dev
Subject: Re: [PATCH 2/2] wiphy: add better handling for rate estimation errors
Date: Thu, 28 Mar 2024 07:19:16 -0700 [thread overview]
Message-ID: <f2a442cf-ab51-405a-85a0-f7af80253304@gmail.com> (raw)
In-Reply-To: <739e21d0-95c5-45ab-8023-d54a128a867a@gmail.com>
On 3/28/24 7:15 AM, Denis Kenzior wrote:
> Hi James,
>
> On 3/28/24 08:47, James Prestwood wrote:
>> In most cases any failure here is likely just due to the AP not
>> supporting the feature, whether its HE/VHT/HE. This should result
>> in the estimation returning -ENOTSUP in which case we move down
>> the list. Any other non-zero return we will now warn to make it
>> clear the IEs did exist, but were not properly formatted.
>>
>> In addition HE specifically has an extra validation function which,
>> if failed, was bailing out of the estimation function entirely.
>> Instead this is now treated as if there was no HE capabilities and
>> the logic can move down to VHT, HT, or basic rates.
>> ---
>> src/wiphy.c | 34 +++++++++++++++++++++++++---------
>> 1 file changed, 25 insertions(+), 9 deletions(-)
>>
>
> <snip>
>
>> @@ -1037,8 +1038,10 @@ int wiphy_estimate_data_rate(struct wiphy *wiphy,
>> vht_operation = iter.data - 2;
>> break;
>> case IE_TYPE_HE_CAPABILITIES:
>> - if (!ie_validate_he_capabilities(iter.data, iter.len))
>> - return -EBADMSG;
>> + if (!ie_validate_he_capabilities(iter.data, iter.len)) {
>> + l_warn("invalid HE capabilities");
>> + continue;
>> + }
>
> I guess you would want to treat all IEs this way? Suppose VHT
> Capabilities is somehow the wrong size?
Sure, that sounds good to me.
>
>> he_capabilities = iter.data;
>> break;
>
> Regards,
> -Denis
>
prev parent reply other threads:[~2024-03-28 14:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-28 13:47 [PATCH 1/2] band: make HE/no-HT rate estimators return more descriptive James Prestwood
2024-03-28 13:47 ` [PATCH 2/2] wiphy: add better handling for rate estimation errors James Prestwood
2024-03-28 14:15 ` Denis Kenzior
2024-03-28 14:19 ` James Prestwood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2a442cf-ab51-405a-85a0-f7af80253304@gmail.com \
--to=prestwoj@gmail.com \
--cc=denkenz@gmail.com \
--cc=iwd@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).