From: Jeff Layton <jlayton@kernel.org>
To: kdevops@lists.linux.dev
Cc: Jeff Layton <jlayton@kernel.org>
Subject: [PATCH 8/8] nfsd: default to a more sane number of threads
Date: Wed, 20 Mar 2024 09:11:31 -0400 [thread overview]
Message-ID: <20240320-fixes-v1-8-d1567776ad50@kernel.org> (raw)
In-Reply-To: <20240320-fixes-v1-0-d1567776ad50@kernel.org>
Add a small script that can estimate the number of threads for
nfsd. We default to 32 threads for every GB of guest memory.
Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
kconfigs/Kconfig.nfsd | 2 +-
scripts/nfsd-thread-est.sh | 15 +++++++++++++++
2 files changed, 16 insertions(+), 1 deletion(-)
diff --git a/kconfigs/Kconfig.nfsd b/kconfigs/Kconfig.nfsd
index dec98c1e964f..7c28ad98955a 100644
--- a/kconfigs/Kconfig.nfsd
+++ b/kconfigs/Kconfig.nfsd
@@ -69,7 +69,7 @@ config NFSD_EXPORT_OPTIONS
config NFSD_THREADS
int "Number of nfsd threads to spawn"
- default 8
+ default $(shell, scripts/nfsd-thread-est.sh)
help
Number of nfsd threads to start up for testing.
diff --git a/scripts/nfsd-thread-est.sh b/scripts/nfsd-thread-est.sh
new file mode 100755
index 000000000000..dc5a1deb1215
--- /dev/null
+++ b/scripts/nfsd-thread-est.sh
@@ -0,0 +1,15 @@
+#!/bin/bash
+#
+# The default number of 8 nfsd threads is pitifully low!
+#
+#
+# Each nfsd thread consumes ~1MB of memory, long-term:
+#
+# stack, kthread overhead, svc_rqst, and the rq_pages array, plus
+# temporary working space.
+#
+# Allow 32 threads for each GB of guest memory:
+
+. "${TOPDIR}/.config"
+
+echo "$(( 32 * $CONFIG_LIBVIRT_MEM_MB / 1024 ))"
--
2.44.0
next prev parent reply other threads:[~2024-03-20 13:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-20 13:11 [PATCH 0/8] kdevops: random fixes Jeff Layton
2024-03-20 13:11 ` [PATCH 1/8] fstests: remove the nfs_default guest Jeff Layton
2024-03-20 13:11 ` [PATCH 2/8] fstests: add an option for testing nfs over rdma Jeff Layton
2024-03-20 13:11 ` [PATCH 3/8] fstests: enable the "codeready" repo on RHEL and CentOS Jeff Layton
2024-03-20 13:11 ` [PATCH 4/8] kotd: display the running kernel version after updating Jeff Layton
2024-03-20 13:11 ` [PATCH 5/8] devconfig: run it on nfsd in addition to the all group Jeff Layton
2024-03-20 13:11 ` [PATCH 6/8] devconfig: don't install dump on redhat family hosts Jeff Layton
2024-03-20 13:11 ` [PATCH 7/8] redhat: fix up some install-deps cases for CentOS Jeff Layton
2024-03-20 13:11 ` Jeff Layton [this message]
2024-03-20 14:10 ` [PATCH 8/8] nfsd: default to a more sane number of threads Chuck Lever
2024-03-20 14:48 ` Jeff Layton
2024-03-20 15:15 ` Chuck Lever
2024-03-20 16:56 ` Jeff Layton
2024-03-20 14:11 ` [PATCH 0/8] kdevops: random fixes Chuck Lever
2024-03-20 14:29 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240320-fixes-v1-8-d1567776ad50@kernel.org \
--to=jlayton@kernel.org \
--cc=kdevops@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).