From: Stefano Garzarella <sgarzare@redhat.com>
To: Andreas Dilger <adilger@dilger.ca>, Kees Cook <keescook@chromium.org>
Cc: Jens Axboe <axboe@kernel.dk>,
Christian Brauner <christian.brauner@ubuntu.com>,
Jann Horn <jannh@google.com>, Jeff Moyer <jmoyer@redhat.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Sargun Dhillon <sargun@sargun.me>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Kernel Hardening <kernel-hardening@lists.openwall.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Aleksa Sarai <asarai@suse.de>,
io-uring@vger.kernel.org
Subject: Re: [PATCH v4 1/3] io_uring: use an enumeration for io_uring_register(2) opcodes
Date: Thu, 27 Aug 2020 09:11:27 +0200 [thread overview]
Message-ID: <20200827071127.iqq4gt3d5bpsq4xu@steredhat.lan> (raw)
In-Reply-To: <C1F49852-C886-4522-ACD6-DDBF7DE3B838@dilger.ca>
On Wed, Aug 26, 2020 at 01:52:38PM -0600, Andreas Dilger wrote:
> On Aug 26, 2020, at 1:43 PM, Kees Cook <keescook@chromium.org> wrote:
> >
> > On Thu, Aug 13, 2020 at 05:32:52PM +0200, Stefano Garzarella wrote:
> >> The enumeration allows us to keep track of the last
> >> io_uring_register(2) opcode available.
> >>
> >> Behaviour and opcodes names don't change.
> >>
> >> Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
> >> ---
> >> include/uapi/linux/io_uring.h | 27 ++++++++++++++++-----------
> >> 1 file changed, 16 insertions(+), 11 deletions(-)
> >>
> >> diff --git a/include/uapi/linux/io_uring.h b/include/uapi/linux/io_uring.h
> >> index d65fde732518..cdc98afbacc3 100644
> >> --- a/include/uapi/linux/io_uring.h
> >> +++ b/include/uapi/linux/io_uring.h
> >> @@ -255,17 +255,22 @@ struct io_uring_params {
> >> /*
> >> * io_uring_register(2) opcodes and arguments
> >> */
> >> -#define IORING_REGISTER_BUFFERS 0
> >> -#define IORING_UNREGISTER_BUFFERS 1
> >> -#define IORING_REGISTER_FILES 2
> >> -#define IORING_UNREGISTER_FILES 3
> >> -#define IORING_REGISTER_EVENTFD 4
> >> -#define IORING_UNREGISTER_EVENTFD 5
> >> -#define IORING_REGISTER_FILES_UPDATE 6
> >> -#define IORING_REGISTER_EVENTFD_ASYNC 7
> >> -#define IORING_REGISTER_PROBE 8
> >> -#define IORING_REGISTER_PERSONALITY 9
> >> -#define IORING_UNREGISTER_PERSONALITY 10
> >> +enum {
> >> + IORING_REGISTER_BUFFERS,
> >
> > Actually, one *tiny* thought. Since this is UAPI, do we want to be extra
> > careful here and explicitly assign values? We can't change the meaning
> > of a number (UAPI) but we can add new ones, etc? This would help if an
> > OP were removed (to stop from triggering a cascade of changed values)...
> >
> > for example:
> >
> > enum {
> > IORING_REGISTER_BUFFERS = 0,
> > IORING_UNREGISTER_BUFFERS = 1,
> > ...
>
> Definitely that is preferred, IMHO, for enums used as part of UAPI,
> as it avoids accidental changes to the values, and it also makes it
> easier to see what the actual values are.
>
Sure, I agree.
I'll put the values in the enumerations in the v5.
Thanks,
Stefano
next prev parent reply other threads:[~2020-08-27 7:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-13 15:32 [PATCH v4 0/3] io_uring: add restrictions to support untrusted applications and guests Stefano Garzarella
2020-08-13 15:32 ` [PATCH v4 1/3] io_uring: use an enumeration for io_uring_register(2) opcodes Stefano Garzarella
2020-08-26 19:40 ` Kees Cook
2020-08-26 19:43 ` Kees Cook
2020-08-26 19:52 ` Andreas Dilger
2020-08-27 7:11 ` Stefano Garzarella [this message]
2020-08-13 15:32 ` [PATCH v4 2/3] io_uring: add IOURING_REGISTER_RESTRICTIONS opcode Stefano Garzarella
2020-08-13 17:42 ` kernel test robot
2020-08-17 10:41 ` Stefano Garzarella
2020-08-26 19:46 ` Kees Cook
2020-08-27 7:12 ` Stefano Garzarella
2020-08-13 15:32 ` [PATCH v4 3/3] io_uring: allow disabling rings during the creation Stefano Garzarella
2020-08-26 19:50 ` Kees Cook
2020-08-27 7:18 ` Stefano Garzarella
2020-08-27 15:04 ` Kees Cook
2020-08-25 15:20 ` [PATCH v4 0/3] io_uring: add restrictions to support untrusted applications and guests Stefano Garzarella
2020-08-26 16:47 ` Jens Axboe
2020-08-26 19:40 ` Kees Cook
2020-08-27 7:24 ` Stefano Garzarella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200827071127.iqq4gt3d5bpsq4xu@steredhat.lan \
--to=sgarzare@redhat.com \
--cc=adilger@dilger.ca \
--cc=asarai@suse.de \
--cc=axboe@kernel.dk \
--cc=christian.brauner@ubuntu.com \
--cc=io-uring@vger.kernel.org \
--cc=jannh@google.com \
--cc=jmoyer@redhat.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sargun@sargun.me \
--cc=stefanha@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).