* Re: [PATCH v3] LoongArch: KVM: Add PMU support
[not found] <20240424091813.1471440-1-gaosong@loongson.cn>
@ 2024-04-25 7:18 ` Markus Elfring
2024-04-29 7:32 ` gaosong
0 siblings, 1 reply; 4+ messages in thread
From: Markus Elfring @ 2024-04-25 7:18 UTC (permalink / raw
To: Song Gao, loongarch, kernel-janitors, maobibo
Cc: LKML, Huacai Chen, Paolo Bonzini, Tianrui Zhao, Wang Xuerui
…
> On KVM side. we save the host PMU CSRs into structure kvm_context.
> If the host supports the PMU feature. When entering guest mode.
> we save the host PMU CSRs and restore the guest PMU CSRs.
…
I suggest to reconsider the usage of a few dots in such a wording approach.
…
Signed-off-by: Song Gao <gaosong@loongson.cn>
v2->V3:
…
* Please put your version descriptions behind a marker line.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9-rc5#n713
* How do you think about to avoid the repetition of version identifiers here?
Regards,
Markus
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3] LoongArch: KVM: Add PMU support
2024-04-25 7:18 ` [PATCH v3] LoongArch: KVM: Add PMU support Markus Elfring
@ 2024-04-29 7:32 ` gaosong
2024-04-29 8:20 ` [v3] " Markus Elfring
0 siblings, 1 reply; 4+ messages in thread
From: gaosong @ 2024-04-29 7:32 UTC (permalink / raw
To: Markus Elfring, loongarch, kernel-janitors, maobibo
Cc: LKML, Huacai Chen, Paolo Bonzini, Tianrui Zhao, Wang Xuerui
在 2024/4/25 下午3:18, Markus Elfring 写道:
> …
>> On KVM side. we save the host PMU CSRs into structure kvm_context.
>> If the host supports the PMU feature. When entering guest mode.
>> we save the host PMU CSRs and restore the guest PMU CSRs.
> …
>
> I suggest to reconsider the usage of a few dots in such a wording approach.
>
>
> …
> Signed-off-by: Song Gao <gaosong@loongson.cn>
>
> v2->V3:
> …
>
> * Please put your version descriptions behind a marker line.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9-rc5#n713
Got it, thank for you suggestion.
> * How do you think about to avoid the repetition of version identifiers here?
I'm new to this, is the following example correct?
[...]
Signed-off-by: Song Gao <gaosong@loongson.cn>
---
v4:
- Use the macro kvm_read_clear_hw_gcsr to optimize the code
and remove redundant code.
V3:
- When saving the PMU context, clear the CTRL register
before reading the CNTR register.
- Put kvm_lose_pmu() in kvm_handler_exit().
v2:
- Add new vcpu->request flag KVM_REQ_PMU. If we use PMU,
We need to set this flag;
- Add kvm_check_pmu() to kvm_pre_enter_guest();
- On _kvm_setcsr(), after modifying the PMU CSR register value,
if we use PMU, we need to set KVM_REQ_PMU.
Patch v3:
https://lore.kernel.org/all/20240424091813.1471440-1-gaosong@loongson.cn/
Patch v2:
https://lore.kernel.org/all/20240417065236.500011-1-gaosong@loongson.cn/
Patch v1:
https://lore.kernel.org/all/20240410095812.2943706-1-gaosong@loongson.cn/
---
[...]
Regards.
Song Gao
>
> Regards,
> Markus
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [v3] LoongArch: KVM: Add PMU support
2024-04-29 7:32 ` gaosong
@ 2024-04-29 8:20 ` Markus Elfring
2024-04-29 9:07 ` gaosong
0 siblings, 1 reply; 4+ messages in thread
From: Markus Elfring @ 2024-04-29 8:20 UTC (permalink / raw
To: Song Gao, loongarch, kernel-janitors, maobibo
Cc: LKML, Huacai Chen, Paolo Bonzini, Tianrui Zhao, Wang Xuerui
>> * How do you think about to avoid the repetition of version identifiers here?
> I'm new to this, is the following example correct?
Different enumeration styles were published.
> ---
>
> v4:
Would you like to specify version identifiers with “V” consistently?
> Patch v1: https://lore.kernel.org/all/20240410095812.2943706-1-gaosong@loongson.cn/
You may specify such links also in each description section directly.
Regards,
Markus
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [v3] LoongArch: KVM: Add PMU support
2024-04-29 8:20 ` [v3] " Markus Elfring
@ 2024-04-29 9:07 ` gaosong
0 siblings, 0 replies; 4+ messages in thread
From: gaosong @ 2024-04-29 9:07 UTC (permalink / raw
To: Markus Elfring, loongarch, kernel-janitors, maobibo
Cc: LKML, Huacai Chen, Paolo Bonzini, Tianrui Zhao, Wang Xuerui
在 2024/4/29 下午4:20, Markus Elfring 写道:
>>> * How do you think about to avoid the repetition of version identifiers here?
>> I'm new to this, is the following example correct?
> Different enumeration styles were published.
>
>
>> ---
>>
>> v4:
> Would you like to specify version identifiers with “V” consistently?
>
Yes. I'll.
>> Patch v1: https://lore.kernel.org/all/20240410095812.2943706-1-gaosong@loongson.cn/
> You may specify such links also in each description section directly.
OK, thank you.
Regards.
Song Gao
> Regards,
> Markus
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-04-29 9:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20240424091813.1471440-1-gaosong@loongson.cn>
2024-04-25 7:18 ` [PATCH v3] LoongArch: KVM: Add PMU support Markus Elfring
2024-04-29 7:32 ` gaosong
2024-04-29 8:20 ` [v3] " Markus Elfring
2024-04-29 9:07 ` gaosong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).