From: "Krzysztof Wilczyński" <kw@linux.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI: endpoint: Remove some unused fields in struct pci_epf_group
Date: Fri, 17 May 2024 20:08:54 +0900 [thread overview]
Message-ID: <20240517110854.GN202520@rocinante> (raw)
In-Reply-To: <6507d44b6c60a19af35a605e2d58050be8872ab6.1712341008.git.christophe.jaillet@wanadoo.fr>
Hello,
> In "struct pci_epf_group", the 'type_group' field is unused.
>
> This was added, but already unused, by commit 70b3740f2c19 ("PCI: endpoint:
> Automatically create a function specific attributes group")
>
> Remove it.
>
> Found with cppcheck, unusedStructMember.
Applied to endpoint, thank you!
[1/1] PCI: endpoint: Remove unused field in struct pci_epf_group
https://git.kernel.org/pci/pci/c/ddc66cc4e695
Krzysztof
prev parent reply other threads:[~2024-05-17 11:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-05 18:16 [PATCH] PCI: endpoint: Remove some unused fields in struct pci_epf_group Christophe JAILLET
2024-05-17 11:08 ` Krzysztof Wilczyński [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240517110854.GN202520@rocinante \
--to=kw@linux.com \
--cc=bhelgaas@google.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=kishon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).