* Re: [PATCH net v5 2/4] ax25: Fix reference count leak issues of ax25_dev
[not found] <86ae9712b610b3d41ce0ce3bbe268c68de6c5914.1715065005.git.duoming@zju.edu.cn>
@ 2024-05-07 9:12 ` Markus Elfring
0 siblings, 0 replies; only message in thread
From: Markus Elfring @ 2024-05-07 9:12 UTC (permalink / raw
To: Dan Carpenter, Duoming Zhou, linux-hams, netdev, kernel-janitors
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Jörg Reuter,
Paolo Abeni, LKML, Lars Kellogg-Stedman, Simon Horman
> The ax25_addr_ax25dev() and ax25_dev_device_down() exist a reference
> count leak issue of the object "ax25_dev".
Please improve this wording.
Suggestion:
Two function implementations contained programming mistakes.
Thus …
> Memory leak issue in ax25_addr_ax25dev():
>
> The reference count of the object "ax25_dev" can be increased multiple
> times in ax25_addr_ax25dev(). This will cause a memory leak so far.
…
* How do you think about to work with indentation in such a description
for item enumeration?
* Would you like to add imperative wordings for improved changelogs?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9-rc7#n94
Regards,
Markus
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-05-07 9:13 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <86ae9712b610b3d41ce0ce3bbe268c68de6c5914.1715065005.git.duoming@zju.edu.cn>
2024-05-07 9:12 ` [PATCH net v5 2/4] ax25: Fix reference count leak issues of ax25_dev Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).