* [PATCH] Input: cros_ec_keyb - Remove an unused field in struct cros_ec_keyb
@ 2024-05-01 6:49 Christophe JAILLET
2024-05-27 2:55 ` patchwork-bot+chrome-platform
2024-05-27 3:07 ` patchwork-bot+chrome-platform
0 siblings, 2 replies; 3+ messages in thread
From: Christophe JAILLET @ 2024-05-01 6:49 UTC (permalink / raw
To: Dmitry Torokhov, Benson Leung, Guenter Roeck
Cc: linux-kernel, kernel-janitors, Christophe JAILLET, linux-input,
chrome-platform
In "struct cros_ec_keyb", the 'keymap_data' field is unused.
Remove it.
Found with cppcheck, unusedStructMember.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
Compile tested only.
It was added in the initial commit 6af6dc2d2aa6 ("input: Add ChromeOS EC
keyboard driver") but was never used.
---
drivers/input/keyboard/cros_ec_keyb.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/input/keyboard/cros_ec_keyb.c b/drivers/input/keyboard/cros_ec_keyb.c
index 30678a34cf64..12eb9df180ee 100644
--- a/drivers/input/keyboard/cros_ec_keyb.c
+++ b/drivers/input/keyboard/cros_ec_keyb.c
@@ -35,7 +35,6 @@
* @rows: Number of rows in the keypad
* @cols: Number of columns in the keypad
* @row_shift: log2 or number of rows, rounded up
- * @keymap_data: Matrix keymap data used to convert to keyscan values
* @ghost_filter: true to enable the matrix key-ghosting filter
* @valid_keys: bitmap of existing keys for each matrix column
* @old_kb_state: bitmap of keys pressed last scan
@@ -50,7 +49,6 @@ struct cros_ec_keyb {
unsigned int rows;
unsigned int cols;
int row_shift;
- const struct matrix_keymap_data *keymap_data;
bool ghost_filter;
uint8_t *valid_keys;
uint8_t *old_kb_state;
--
2.44.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Input: cros_ec_keyb - Remove an unused field in struct cros_ec_keyb
2024-05-01 6:49 [PATCH] Input: cros_ec_keyb - Remove an unused field in struct cros_ec_keyb Christophe JAILLET
@ 2024-05-27 2:55 ` patchwork-bot+chrome-platform
2024-05-27 3:07 ` patchwork-bot+chrome-platform
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+chrome-platform @ 2024-05-27 2:55 UTC (permalink / raw
To: Christophe JAILLET
Cc: dmitry.torokhov, bleung, groeck, linux-kernel, kernel-janitors,
linux-input, chrome-platform
Hello:
This patch was applied to chrome-platform/linux.git (for-kernelci)
by Dmitry Torokhov <dmitry.torokhov@gmail.com>:
On Wed, 1 May 2024 08:49:47 +0200 you wrote:
> In "struct cros_ec_keyb", the 'keymap_data' field is unused.
> Remove it.
>
> Found with cppcheck, unusedStructMember.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
>
> [...]
Here is the summary with links:
- Input: cros_ec_keyb - Remove an unused field in struct cros_ec_keyb
https://git.kernel.org/chrome-platform/c/5128de84d8fc
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Input: cros_ec_keyb - Remove an unused field in struct cros_ec_keyb
2024-05-01 6:49 [PATCH] Input: cros_ec_keyb - Remove an unused field in struct cros_ec_keyb Christophe JAILLET
2024-05-27 2:55 ` patchwork-bot+chrome-platform
@ 2024-05-27 3:07 ` patchwork-bot+chrome-platform
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+chrome-platform @ 2024-05-27 3:07 UTC (permalink / raw
To: Christophe JAILLET
Cc: dmitry.torokhov, bleung, groeck, linux-kernel, kernel-janitors,
linux-input, chrome-platform
Hello:
This patch was applied to chrome-platform/linux.git (for-next)
by Dmitry Torokhov <dmitry.torokhov@gmail.com>:
On Wed, 1 May 2024 08:49:47 +0200 you wrote:
> In "struct cros_ec_keyb", the 'keymap_data' field is unused.
> Remove it.
>
> Found with cppcheck, unusedStructMember.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
>
> [...]
Here is the summary with links:
- Input: cros_ec_keyb - Remove an unused field in struct cros_ec_keyb
https://git.kernel.org/chrome-platform/c/5128de84d8fc
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-05-27 3:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-01 6:49 [PATCH] Input: cros_ec_keyb - Remove an unused field in struct cros_ec_keyb Christophe JAILLET
2024-05-27 2:55 ` patchwork-bot+chrome-platform
2024-05-27 3:07 ` patchwork-bot+chrome-platform
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).