From: Chuck Lever III <chuck.lever@oracle.com>
To: Hannes Reinecke <hare@suse.de>
Cc: "kernel-tls-handshake@lists.linux.dev"
<kernel-tls-handshake@lists.linux.dev>
Subject: Re: Misc fixes for v5
Date: Fri, 3 Mar 2023 18:28:31 +0000 [thread overview]
Message-ID: <3C0C9E55-F109-403B-AB67-62B35753E348@oracle.com> (raw)
In-Reply-To: <c9c2af40-b5fe-a49b-ce58-dc90d0dbe199@suse.de>
> On Mar 3, 2023, at 11:38 AM, Hannes Reinecke <hare@suse.de> wrote:
>
> On 3/3/23 16:28, Chuck Lever III wrote:
>>> On Mar 3, 2023, at 10:08 AM, Hannes Reinecke <hare@suse.de> wrote:
>>>
>>> Hi Chuck,
>>>
>>> after some fiddling with nested arguments (and eventually removing them) I found some issues with v5.
>>> (cf the attached patch).
>> I plan to post a v6 soon that supports:
>> - a timeout attribute
>> - keyrings
>> - multiple certs and peerids per handshake
>> I still don't like the timeout attribute.
>> - Having timeouts at two layers is a known recipe for tears and
>> sorrow.
>> - The kernel can't rely on the handshake agent to timeout and
>> call DONE. If the agent exits before invoking DONE, there will
>> be no handshake completion.
>> But it's not a hill I care to die on, so I added it.
> Yeah, and that's the point where the socket is closed; once
> the userspace daemon finally gives up it'll close the connection
> (for reasons still be to figured out).
Could be because your kernel consumer isn't holding a struct
file on that socket...? When the user fd is closed, that's
the last reference on that filp and the kernel closes the
socket right there.
--
Chuck Lever
prev parent reply other threads:[~2023-03-03 18:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-03 15:08 Misc fixes for v5 Hannes Reinecke
2023-03-03 15:28 ` Chuck Lever III
2023-03-03 16:38 ` Hannes Reinecke
2023-03-03 18:28 ` Chuck Lever III [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C0C9E55-F109-403B-AB67-62B35753E348@oracle.com \
--to=chuck.lever@oracle.com \
--cc=hare@suse.de \
--cc=kernel-tls-handshake@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).