From: Sagi Grimberg <sagi@grimberg.me>
To: Hannes Reinecke <hare@suse.de>, Christoph Hellwig <hch@lst.de>
Cc: Jakub Kicinski <kuba@kernel.org>, Keith Busch <kbusch@kernel.org>,
linux-nvme@lists.infradead.org,
Chuck Lever <chuck.lever@oracle.com>,
kernel-tls-handshake@lists.linux.dev,
Boris Pismenny <boris.pismenny@gmail.com>,
David Howells <dhowells@redhat.com>
Subject: Re: [PATCH 06/17] net/tls: implement ->read_sock()
Date: Wed, 17 May 2023 12:36:04 +0300 [thread overview]
Message-ID: <70f0e567-95f1-4c88-a4ca-3357524a5c6a@grimberg.me> (raw)
In-Reply-To: <4d1f5afe-628c-ee5b-c6b9-59d59c184f42@suse.de>
> On 5/17/23 09:54, Christoph Hellwig wrote:
>> On Wed, May 17, 2023 at 09:53:10AM +0200, Hannes Reinecke wrote:
>>> Problem is the MSG_SPLIC patchset from David Howells; that
>>> essentially does
>>> away with ->sendpage().
>>> So I'm not sure how to go from here; wait for the patchset to land, and
>>> rebase my patches on top of that, or proactively switch away from
>>> ->sendpage() and resubmit directly.
>>
>> I'd wait for it. It should make life a lot simpler.
>>
> Same thought here.
> Let's see.
Did you test that you don't need to change anything with nvme-tcp
on top of the SPLICE_PAGES series from David?
next prev parent reply other threads:[~2023-05-17 9:36 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-19 6:56 [PATCHv4 00/17] nvme: In-kernel TLS support for TCP Hannes Reinecke
2023-04-19 6:56 ` [PATCH 01/17] nvme-keyring: register '.nvme' keyring Hannes Reinecke
2023-05-02 14:17 ` Aurelien Aptel
2023-04-19 6:56 ` [PATCH 02/17] nvme-keyring: define a 'psk' keytype Hannes Reinecke
2023-05-08 8:59 ` Max Gurtovoy
2023-05-08 13:56 ` Hannes Reinecke
2023-04-19 6:57 ` [PATCH 03/17] nvme: add TCP TSAS definitions Hannes Reinecke
2023-05-08 16:36 ` Max Gurtovoy
2023-05-08 21:01 ` Hannes Reinecke
2023-04-19 6:57 ` [PATCH 04/17] nvme-tcp: add definitions for TLS cipher suites Hannes Reinecke
2023-04-19 6:57 ` [PATCH 05/17] nvme-keyring: implement nvme_tls_psk_default() Hannes Reinecke
2023-05-09 7:31 ` Max Gurtovoy
2023-05-09 14:13 ` Hannes Reinecke
2023-04-19 6:57 ` [PATCH 06/17] net/tls: implement ->read_sock() Hannes Reinecke
2023-04-19 9:09 ` Sagi Grimberg
2023-05-09 23:30 ` Sagi Grimberg
2023-05-10 0:47 ` Jakub Kicinski
2023-05-17 6:43 ` Sagi Grimberg
2023-05-17 7:53 ` Hannes Reinecke
2023-05-17 7:54 ` Christoph Hellwig
2023-05-17 7:56 ` Hannes Reinecke
2023-05-17 9:36 ` Sagi Grimberg [this message]
2023-04-19 6:57 ` [PATCH 07/17] net/tls: handle MSG_EOR for tls_sw TX flow Hannes Reinecke
2023-05-09 9:19 ` Max Gurtovoy
2023-05-09 14:18 ` Hannes Reinecke
2023-05-09 15:13 ` Jakub Kicinski
2023-05-09 23:02 ` Max Gurtovoy
2023-05-09 23:07 ` Hannes Reinecke
2023-04-19 6:57 ` [PATCH 08/17] nvme-tcp: fixup MSG_SENDPAGE_NOTLAST Hannes Reinecke
2023-04-19 9:08 ` Sagi Grimberg
2023-04-19 6:57 ` [PATCH 09/17] security/keys: export key_lookup() Hannes Reinecke
2023-04-19 6:57 ` [PATCH 10/17] nvme/tcp: allocate socket file Hannes Reinecke
2023-04-19 6:57 ` [PATCH 11/17] nvme-tcp: enable TLS handshake upcall Hannes Reinecke
2023-05-09 9:48 ` Max Gurtovoy
2023-05-09 14:22 ` Hannes Reinecke
2023-05-09 23:16 ` Max Gurtovoy
2023-05-10 7:37 ` Hannes Reinecke
2023-04-19 6:57 ` [PATCH 12/17] nvme-tcp: control message handling for recvmsg() Hannes Reinecke
2023-04-19 6:57 ` [PATCH 13/17] nvme-fabrics: parse options 'keyring' and 'tls_key' Hannes Reinecke
2023-04-21 6:32 ` Daniel Wagner
2023-05-09 10:00 ` Max Gurtovoy
2023-05-09 14:24 ` Hannes Reinecke
2023-04-19 6:57 ` [PATCH 14/17] nvmet: make TCP sectype settable via configfs Hannes Reinecke
2023-04-19 6:57 ` [PATCH 15/17] nvmet-tcp: allocate socket file Hannes Reinecke
2023-04-19 6:57 ` [PATCH 16/17] nvmet-tcp: enable TLS handshake upcall Hannes Reinecke
2023-04-19 6:57 ` [PATCH 17/17] nvmet-tcp: control messages for recvmsg() Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70f0e567-95f1-4c88-a4ca-3357524a5c6a@grimberg.me \
--to=sagi@grimberg.me \
--cc=boris.pismenny@gmail.com \
--cc=chuck.lever@oracle.com \
--cc=dhowells@redhat.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kernel-tls-handshake@lists.linux.dev \
--cc=kuba@kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).