From: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
Robin Murphy <robin.murphy@arm.com>,
Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Leon Romanovsky <leonro@nvidia.com>,
Easwar Hariharan <eahariha@linux.microsoft.com>,
linux-kernel@vger.kernel.org, iommu@lists.linux.dev,
Jason Gunthorpe <jgg@nvidia.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
regressions@lists.linux.dev, kernelci@lists.linux.dev,
kernel@collabora.com
Subject: Re: [PATCH v4 2/2] dma: add IOMMU static calls with clear default ops
Date: Tue, 10 Sep 2024 15:01:05 -0400 [thread overview]
Message-ID: <181e06ff-35a3-434f-b505-672f430bd1cb@notapiano> (raw)
In-Reply-To: <c3179690b16d790d5bfd7d0afabac9b90922ec28.1721818168.git.leon@kernel.org>
On Wed, Jul 24, 2024 at 09:04:49PM +0300, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@nvidia.com>
>
> Most of the arch DMA ops (which often, but not always, involve
> some sort of IOMMU) are using the same DMA operations, but for all
> modern platforms dma-iommu implementation is really matters.
>
> So let's make sure to call them directly without need to perform
> function pointers dereference.
>
> During system initialization, the arch can set its own DMA and in such
> case, the default DMA operations will be overridden.
>
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
> Signed-off-by: Leon Romanovsky <leon@kernel.org>
Hi,
KernelCI has identified another regression originating from this patch. It
affects the same platforms:
* sc7180-trogdor-kingoftown
* sc7180-trogdor-lazor-limozeen
But this time the issue is that the venus video codecs are failing to probe as
indicated by the DT kselftest:
not ok 184 /soc@0/video-codec@aa00000
ok 185 /soc@0/video-codec@aa00000/opp-table # SKIP
not ok 186 /soc@0/video-codec@aa00000/video-decoder
not ok 187 /soc@0/video-codec@aa00000/video-encoder
The kernel logs show the error:
qcom-venus aa00000.video-codec: probe with driver qcom-venus failed with error -5
A quick ftrace run showed that the error comes from dma_set_mask_and_coherent()
in venus_probe():
7) | venus_probe() {
...
7) | dma_set_mask() {
7) | dma_supported() {
7) 0.989 us | dma_direct_supported(); /* = 0x0 */
7) 2.864 us | } /* dma_supported = 0x0 */
7) 4.636 us | } /* dma_set_mask = -5 */
For comparison, here is the ftrace run with the commit reverted:
7) | venus_probe() {
...
7) 1.093 us | dma_set_mask(); /* = 0x0 */
7) 1.041 us | dma_set_coherent_mask(); /* = 0x0 */
The issue is still present as of next-20240909 and reverting this commit fixes
it.
Happy to provide any other details necessary.
Please add
Reported-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> #KernelCI
when fixing this.
#regzbot introduced: next-20240822..20240823
#regzbot title: Venus codec probe regression for sc7180 platforms in dma_set_mask_and_coherent()
Thanks,
Nícolas
next prev parent reply other threads:[~2024-09-10 19:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1721818168.git.leon@kernel.org>
[not found] ` <c3179690b16d790d5bfd7d0afabac9b90922ec28.1721818168.git.leon@kernel.org>
2024-09-04 14:59 ` [PATCH v4 2/2] dma: add IOMMU static calls with clear default ops Nícolas F. R. A. Prado
2024-09-04 15:45 ` Leon Romanovsky
2024-09-04 17:58 ` Nícolas F. R. A. Prado
2024-09-04 18:02 ` Leon Romanovsky
2024-09-10 19:01 ` Nícolas F. R. A. Prado [this message]
2024-09-11 6:43 ` Leon Romanovsky
2024-09-11 8:04 ` Christoph Hellwig
2024-09-11 9:05 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=181e06ff-35a3-434f-b505-672f430bd1cb@notapiano \
--to=nfraprado@collabora.com \
--cc=eahariha@linux.microsoft.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=iommu@lists.linux.dev \
--cc=jgg@nvidia.com \
--cc=joro@8bytes.org \
--cc=kernel@collabora.com \
--cc=kernelci@lists.linux.dev \
--cc=leon@kernel.org \
--cc=leonro@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=regressions@lists.linux.dev \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).