From: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
To: Sean Wang <sean.wang@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Bamvor Jian Zhang <bamv2005@gmail.com>,
Shuah Khan <shuah@kernel.org>
Cc: kernel@collabora.com, linux-mediatek@lists.infradead.org,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kselftest@vger.kernel.org, kernelci@lists.linux.dev,
"Nícolas F. R. A. Prado" <nfraprado@collabora.com>
Subject: [PATCH RFC v2 4/5] selftest: gpio: Add wait flag to gpio-mockup-cdev
Date: Fri, 25 Oct 2024 15:45:39 -0400 [thread overview]
Message-ID: <20241025-kselftest-gpio-set-get-config-v2-4-040d748840bb@collabora.com> (raw)
In-Reply-To: <20241025-kselftest-gpio-set-get-config-v2-0-040d748840bb@collabora.com>
Add a -w flag to the gpio-mockup-cdev utility that causes the program to
wait until a signal is received before exiting, even when its behavior
is to retrieve the GPIO value of the line. This allows using this
utility to keep a GPIO line configured even when in input mode, which
will be relied on in other tests.
Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
---
tools/testing/selftests/gpio/gpio-mockup-cdev.c | 14 +++++++++++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/tools/testing/selftests/gpio/gpio-mockup-cdev.c b/tools/testing/selftests/gpio/gpio-mockup-cdev.c
index d1640f44f8ac2a6fda7a5f75605f83fcaa165dc0..f674dcafa60a02cb1739f3cfae8963dc09efba74 100644
--- a/tools/testing/selftests/gpio/gpio-mockup-cdev.c
+++ b/tools/testing/selftests/gpio/gpio-mockup-cdev.c
@@ -15,6 +15,7 @@
#include <unistd.h>
#include <sys/ioctl.h>
#include <linux/gpio.h>
+#include <stdbool.h>
#define CONSUMER "gpio-mockup-cdev"
@@ -95,6 +96,7 @@ static void usage(char *prog)
printf(" (default is to leave bias unchanged):\n");
printf(" -l: set line active low (default is active high)\n");
printf(" -s: set line value (default is to get line value)\n");
+ printf(" -w: wait even in get mode\n");
printf(" -u: uAPI version to use (default is 2)\n");
exit(-1);
}
@@ -120,13 +122,14 @@ int main(int argc, char *argv[])
unsigned int offset, val = 0, abiv;
uint32_t flags_v1;
uint64_t flags_v2;
+ bool wait = false;
abiv = 2;
ret = 0;
flags_v1 = GPIOHANDLE_REQUEST_INPUT;
flags_v2 = GPIO_V2_LINE_FLAG_INPUT;
- while ((opt = getopt(argc, argv, "lb:s:u:")) != -1) {
+ while ((opt = getopt(argc, argv, "lb:s:u:w")) != -1) {
switch (opt) {
case 'l':
flags_v1 |= GPIOHANDLE_REQUEST_ACTIVE_LOW;
@@ -150,10 +153,14 @@ int main(int argc, char *argv[])
flags_v1 |= GPIOHANDLE_REQUEST_OUTPUT;
flags_v2 &= ~GPIO_V2_LINE_FLAG_INPUT;
flags_v2 |= GPIO_V2_LINE_FLAG_OUTPUT;
+ wait = true;
break;
case 'u':
abiv = atoi(optarg);
break;
+ case 'w':
+ wait = true;
+ break;
default:
usage(argv[0]);
}
@@ -183,9 +190,10 @@ int main(int argc, char *argv[])
return lfd;
}
- if (flags_v2 & GPIO_V2_LINE_FLAG_OUTPUT) {
+ if (wait)
wait_signal();
- } else {
+
+ if (flags_v2 & GPIO_V2_LINE_FLAG_INPUT) {
if (abiv == 1)
ret = get_value_v1(lfd);
else
--
2.47.0
next prev parent reply other threads:[~2024-10-25 19:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-25 19:45 [PATCH RFC v2 0/5] Verify bias functionality for pinctrl_paris driver through new gpio test Nícolas F. R. A. Prado
2024-10-25 19:45 ` [PATCH RFC v2 1/5] pinctrl: mediatek: paris: Expose more configurations to GPIO set_config Nícolas F. R. A. Prado
2024-11-01 7:41 ` Chen-Yu Tsai
2024-10-25 19:45 ` [PATCH RFC v2 2/5] pinctrl: mediatek: moore: " Nícolas F. R. A. Prado
2024-11-01 7:54 ` Chen-Yu Tsai
2024-10-25 19:45 ` [PATCH RFC v2 3/5] pinctrl: mediatek: common: " Nícolas F. R. A. Prado
2024-11-01 7:54 ` Chen-Yu Tsai
2024-11-01 12:04 ` Nícolas F. R. A. Prado
2024-10-25 19:45 ` Nícolas F. R. A. Prado [this message]
2024-10-28 14:36 ` [PATCH RFC v2 4/5] selftest: gpio: Add wait flag to gpio-mockup-cdev Linus Walleij
2024-10-25 19:45 ` [PATCH RFC v2 5/5] selftest: gpio: Add a new set-get config test Nícolas F. R. A. Prado
2024-10-28 14:37 ` Linus Walleij
2024-10-28 14:02 ` [PATCH RFC v2 0/5] Verify bias functionality for pinctrl_paris driver through new gpio test Nícolas F. R. A. Prado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241025-kselftest-gpio-set-get-config-v2-4-040d748840bb@collabora.com \
--to=nfraprado@collabora.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bamv2005@gmail.com \
--cc=kernel@collabora.com \
--cc=kernelci@lists.linux.dev \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=sean.wang@kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).