From: Lukas Wunner <lukas@wunner.de>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: David Howells <dhowells@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
keyrings@vger.kernel.org, linux-crypto@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Dan Williams <dan.j.williams@intel.com>,
Ard Biesheuvel <ardb@kernel.org>
Subject: Re: [PATCH] X.509: Introduce scope-based x509_certificate allocation
Date: Mon, 12 Feb 2024 12:39:16 +0100 [thread overview]
Message-ID: <20240212113916.GB15065@wunner.de> (raw)
In-Reply-To: <ZbNFGC4q0Yy6RPNe@gondor.apana.org.au>
On Fri, Jan 26, 2024 at 01:37:28PM +0800, Herbert Xu wrote:
> On Sun, Jan 21, 2024 at 06:50:39PM +0100, Lukas Wunner wrote:
> >
> > * x509_cert_parse() now checks that "cert" is not an ERR_PTR() before
> > calling x509_free_certificate() at end of scope. The compiler doesn't
> > know that kzalloc() never returns an ERR_PTR().
>
> How about moving the IS_ERR_OR_NULL check into x509_free_certificate
> itself so that you can always call it?
Thanks for the suggestion. Indeed the NULL check is unnecessary
as x509_free_certificate() already checks that. So in v2 I'm only
checking for !IS_ERR() in the DEFINE_FREE() clause and that avoids
the gratuitous NULL pointer checks at end of scope.
Lukas
prev parent reply other threads:[~2024-02-12 11:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-21 17:50 [PATCH] X.509: Introduce scope-based x509_certificate allocation Lukas Wunner
2024-01-22 19:29 ` Jarkko Sakkinen
2024-02-12 11:35 ` Lukas Wunner
2024-01-26 5:37 ` Herbert Xu
2024-01-28 13:32 ` Andy Shevchenko
2024-01-29 2:32 ` Herbert Xu
2024-02-12 11:39 ` Lukas Wunner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240212113916.GB15065@wunner.de \
--to=lukas@wunner.de \
--cc=Jonathan.Cameron@huawei.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=ardb@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).