From: David Howells <dhowells@redhat.com>
To: Jarkko Sakkinen <jarkko@kernel.org>
Cc: David Howells <dhowells@redhat.com>,
keyrings@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 0/7] keyutils: Add some fixes and updates
Date: Fri, 22 Aug 2025 15:22:07 +0100 [thread overview]
Message-ID: <20250822142215.2475014-1-dhowells@redhat.com> (raw)
Hi Jarkko,
Here are some patches that I'm proposing to add to keyutils:
(1) Fix a couple of potential signed overflows in the library.
(2) In request-key, fix the mishandling of the last line of the
request-key.conf file if it doesn't have a newline at the end.
(3) In the tests, hide the endianness of raw binary content (such as
keyring content) by using od to byteswap it appropriately rather than
trying to do this manually.
(4) In the tests, add skips for unsupported features.
(5) In request-key, add help text if "--help" is given or no parameters
are given.
(6) Add a simpler way to do configuration testing:
request-key --check [-lnv] type desc [info] [op]
(7) Add support for multiwildcard matching in request-key.conf. This can
be tested with:
request-key --match [-v] pattern datum [datum...]
Apologies, some of these should have been committed a while ago.
David
David Howells (7):
lib: Fix a couple of potential signed oveflows
request-key: Fix mishandling of last line of config file
test: Hide endianness
tests: Add skips for testing of unsupported features
request-key: Add help text
request-key: Add a simpler debug test
request-key: Support the promised multiwildcard matching
keyutils.c | 5 +
man/request-key.8 | 85 +++-
request-key.c | 504 ++++++++++++++++------
tests/features/limits/runtest.sh | 6 +
tests/hex2bin.pl | 21 +
tests/keyctl/id/bad-args/runtest.sh | 6 +
tests/keyctl/id/noargs/runtest.sh | 6 +
tests/keyctl/id/valid/runtest.sh | 6 +
tests/keyctl/move/bad-args/runtest.sh | 6 +
tests/keyctl/move/noargs/runtest.sh | 6 +
tests/keyctl/move/recursion/runtest.sh | 6 +
tests/keyctl/move/valid/runtest.sh | 6 +
tests/keyctl/reading/valid/runtest.sh | 9 +-
tests/keyctl/session/valid2/runtest.sh | 6 +
tests/keyctl/supports/bad-args/runtest.sh | 6 +
tests/keyctl/supports/valid/runtest.sh | 6 +
tests/prepare.inc.sh | 23 +-
tests/toolbox.inc.sh | 69 ++-
18 files changed, 619 insertions(+), 163 deletions(-)
create mode 100644 tests/hex2bin.pl
next reply other threads:[~2025-08-22 14:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-22 14:22 David Howells [this message]
2025-08-22 14:22 ` [PATCH 1/7] lib: Fix a couple of potential signed oveflows David Howells
2025-08-23 23:25 ` Jarkko Sakkinen
2025-08-22 14:22 ` [PATCH 2/7] request-key: Fix mishandling of last line of config file David Howells
2025-08-23 23:59 ` Jarkko Sakkinen
2025-11-19 15:53 ` David Howells
2025-08-22 14:22 ` [PATCH 3/7] test: Hide endianness David Howells
2025-08-22 14:22 ` [PATCH 4/7] tests: Add skips for testing of unsupported features David Howells
2025-08-22 14:22 ` [PATCH 5/7] request-key: Add help text David Howells
2025-08-24 0:03 ` Jarkko Sakkinen
2025-08-22 14:22 ` [PATCH 6/7] request-key: Add a simpler debug test David Howells
2025-08-24 0:04 ` Jarkko Sakkinen
2025-08-22 14:22 ` [PATCH 7/7] request-key: Support the promised multiwildcard matching David Howells
2025-08-24 0:05 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250822142215.2475014-1-dhowells@redhat.com \
--to=dhowells@redhat.com \
--cc=jarkko@kernel.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).