From: David Howells <dhowells@redhat.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: dhowells@redhat.com, Jarkko Sakkinen <jarkko@kernel.org>,
Kees Cook <kees@kernel.org>, Greg KH <gregkh@linuxfoundation.org>,
Josh Drake <josh@delphoslabs.com>,
Suraj Sonawane <surajsonawane0215@gmail.com>,
keyrings@vger.kernel.org, linux-security-module@vger.kernel.org,
security@kernel.org, stable@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] keys: Fix UAF in key_put()
Date: Tue, 18 Mar 2025 13:27:54 +0000 [thread overview]
Message-ID: <2526768.1742304474@warthog.procyon.org.uk> (raw)
In-Reply-To: <20250318113655.GB14792@redhat.com>
Oleg Nesterov <oleg@redhat.com> wrote:
> and since key_user_put() takes key_user_lock with irqs enabled,
> key_put()->key_user_put() doesn't look correct...
Meh. Yeah. I think it's time to do it the other way (i.e. putting keys to be
destroyed onto an explicit cleanup queue).
David
prev parent reply other threads:[~2025-03-18 13:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-18 10:14 [PATCH] keys: Fix UAF in key_put() David Howells
2025-03-18 11:22 ` Oleg Nesterov
2025-03-18 11:36 ` Oleg Nesterov
2025-03-18 13:27 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2526768.1742304474@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jarkko@kernel.org \
--cc=josh@delphoslabs.com \
--cc=kees@kernel.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=security@kernel.org \
--cc=stable@vger.kernel.org \
--cc=surajsonawane0215@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).