From: David Howells <dhowells@redhat.com>
To: Nicolas Schier <nicolas.schier@linux.dev>
Cc: dhowells@redhat.com, "longguang.yue" <bigclouds@163.com>,
linux-kbuild@vger.kernel.org, nathan@kernel.org,
masahiroy@kernel.org, David Woodhouse <dwmw2@infradead.org>,
keyrings@vger.kernel.org
Subject: Re: [PATCH] Makefile: mrproper deletes signing_key.x509
Date: Tue, 12 Aug 2025 10:31:15 +0100 [thread overview]
Message-ID: <650213.1754991075@warthog.procyon.org.uk> (raw)
In-Reply-To: <20250811-diligent-rigorous-ara-e7a9d2@l-nschier-aarch64>
Nicolas Schier <nicolas.schier@linux.dev> wrote:
> 'make mrproper' is meant to prepare the source tree to be as pristine as
> possible for the given architecture. This includes removal of any
> configuration file(s) that influence subsequent builds. From kbuild
> point of view, certs/x509.genkey is also a kind of a configuration file,
> as leaving it in tree after mrproper creates different build results
> compared to a build from a really pristine source tree.
>
> Iff the certs/ maintainers think that retaining a user x509.genkey file
> over a mrproper makes sense, then we should probably adjust the rule for
> generating $(objtree)/certs/x509.genkey, e.g. by allowing to provide one
> by environment variable.
>
> David or David, do you have an opinion on this?
make distclean or make mrproper should delete the key. As you say, it's
thoroughly cleaning out the source tree - it used to be so that you could more
easily diff it for prepping a patch, I guess. make clean, OTOH, should not.
David
prev parent reply other threads:[~2025-08-12 9:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250809120405.22957-1-bigclouds@163.com>
[not found] ` <aJerjQGmXXcpTtBB@fjasle.eu>
[not found] ` <1ac1d3e3.58ad.19897d159ff.Coremail.bigclouds@163.com>
2025-08-11 13:59 ` [PATCH] Makefile: mrproper deletes signing_key.x509 Nicolas Schier
2025-08-11 19:14 ` Nathan Chancellor
2025-08-12 2:22 ` longguang.yue
2025-08-12 9:31 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=650213.1754991075@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=bigclouds@163.com \
--cc=dwmw2@infradead.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
--cc=nicolas.schier@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).