From: Luis Henriques <luis.henriques@linux.dev>
To: "Jarkko Sakkinen" <jarkko@kernel.org>
Cc: "David Howells" <dhowells@redhat.com>,
"Eric Biggers" <ebiggers@kernel.org>,
<keyrings@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] keys: update key quotas in key_put()
Date: Mon, 18 Mar 2024 21:38:05 +0000 [thread overview]
Message-ID: <87plvr9q6a.fsf@camandro.org> (raw)
In-Reply-To: <CZX6QS05JAHA.M82GVT11TIQC@kernel.org> (Jarkko Sakkinen's message of "Mon, 18 Mar 2024 23:14:55 +0200")
"Jarkko Sakkinen" <jarkko@kernel.org> writes:
> On Wed Mar 13, 2024 at 2:37 PM EET, Luis Henriques wrote:
>> Luis Henriques <lhenriques@suse.de> writes:
>>
>> > David Howells <dhowells@redhat.com> writes:
>> >
>> >> Luis Henriques <lhenriques@suse.de> wrote:
>> >>
>> >>> Delaying key quotas update when key's refcount reaches 0 in key_put() has
>> >>> been causing some issues in fscrypt testing, specifically in fstest
>> >>> generic/581. This commit fixes this test flakiness by dealing with the
>> >>> quotas immediately, and leaving all the other clean-ups to the key garbage
>> >>> collector.
>> >>
>> >> Okay, I'll accept this.
>> >>
>> >
>> > That's awesome, thanks a lot David. And, as Eric requested, I'll send out
>> > shortly a follow-up fscrypt-specific patch, which will make generic/581
>> > fstest finally pass.
>>
>> Ping. Looks like this fell through the cracks...?
>>
>> I took a quick look at some git trees ('jarkko' and 'dhowells') but
>> couldn't see this patch anywhere.
>>
>> Cheers,
>
> My bad! I'll pick this up now.
Awesome, thanks a lot Jarkko.
Cheers,
--
Luis
prev parent reply other threads:[~2024-03-18 21:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 10:13 [PATCH v3] keys: update key quotas in key_put() Luis Henriques
2024-01-30 17:27 ` Jarkko Sakkinen
2024-02-05 12:04 ` David Howells
2024-02-05 13:54 ` Luis Henriques
2024-03-13 12:37 ` Luis Henriques
2024-03-18 21:14 ` Jarkko Sakkinen
2024-03-18 21:37 ` Jarkko Sakkinen
2024-03-18 21:38 ` Luis Henriques [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87plvr9q6a.fsf@camandro.org \
--to=luis.henriques@linux.dev \
--cc=dhowells@redhat.com \
--cc=ebiggers@kernel.org \
--cc=jarkko@kernel.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).