From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: David Howells <dhowells@redhat.com>
Cc: Eric Biggers <ebiggers@kernel.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
Luis Chamberlain <mcgrof@kernel.org>,
Petr Pavlu <petr.pavlu@suse.com>,
Daniel Gomez <da.gomez@kernel.org>,
Sami Tolvanen <samitolvanen@google.com>,
Ard Biesheuvel <ardb@kernel.org>,
Stephan Mueller <smueller@chronox.de>,
Lukas Wunner <lukas@wunner.de>,
Ignat Korchagin <ignat@cloudflare.com>,
linux-crypto@vger.kernel.org, keyrings@vger.kernel.org,
linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v10 5/8] crypto: Add ML-DSA crypto_sig support
Date: Mon, 24 Nov 2025 19:06:20 +0100 [thread overview]
Message-ID: <CAHmME9pPWGKAdm83wKhc3iHCjgZ8gOtZnt=+6x5V6D1prMb2Gw@mail.gmail.com> (raw)
In-Reply-To: <3647621.1764005088@warthog.procyon.org.uk>
On Mon, Nov 24, 2025 at 6:25 PM David Howells <dhowells@redhat.com> wrote:
>
> Eric Biggers <ebiggers@kernel.org> wrote:
>
> > Still not really sure what the point is. There's only one user of
> > crypto_sig, and it could just call the ML-DSA functions directly.
>
> Is it your aim to kill off the crypto/ dir and all the (old) crypto API?
Probably entirely killing off the old API is going to be fraught
because its abstraction has leaked out to userspace. But to the extent
we can minimize its use over time, I think that's a good thing. Even
for crypto usages that generalize to a few different ciphers of one
variety or another, I think being explicit about which ciphers and
having purpose-built dispatchers is usually a better route.
Jason
next prev parent reply other threads:[~2025-11-24 18:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-20 10:44 [PATCH v10 0/8] lib/crypto: Add ML-DSA signing [WIP] David Howells
2025-11-20 10:44 ` [PATCH v10 1/8] lib/crypto: Add ML-DSA verification support David Howells
2025-11-20 10:44 ` [PATCH v10 2/8] lib/crypto: tests: Add KUnit tests for ML-DSA David Howells
2025-11-20 10:44 ` [PATCH v10 3/8] lib/crypto: tests: Add ML-DSA-65 test cases David Howells
2025-11-20 10:44 ` [PATCH v10 4/8] lib/crypto: tests: Add ML-DSA-87 " David Howells
2025-11-20 10:44 ` [PATCH v10 5/8] crypto: Add ML-DSA crypto_sig support David Howells
2025-11-24 9:12 ` David Howells
2025-11-24 16:49 ` Eric Biggers
2025-11-24 17:24 ` David Howells
2025-11-24 18:06 ` Jason A. Donenfeld [this message]
2025-11-24 19:54 ` David Howells
2025-11-24 20:10 ` Jason A. Donenfeld
2025-11-24 20:27 ` Eric Biggers
2025-11-24 20:43 ` David Howells
2025-11-24 16:58 ` Elliott, Robert (Servers)
2025-11-20 10:44 ` [PATCH v10 6/8] pkcs7: Allow the signing algo to calculate the digest itself David Howells
2025-11-20 10:44 ` [PATCH v10 7/8] pkcs7, x509: Add ML-DSA support David Howells
2025-11-20 10:44 ` [PATCH v10 8/8] modsign: Enable ML-DSA module signing David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHmME9pPWGKAdm83wKhc3iHCjgZ8gOtZnt=+6x5V6D1prMb2Gw@mail.gmail.com' \
--to=jason@zx2c4.com \
--cc=ardb@kernel.org \
--cc=da.gomez@kernel.org \
--cc=dhowells@redhat.com \
--cc=ebiggers@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=ignat@cloudflare.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mcgrof@kernel.org \
--cc=petr.pavlu@suse.com \
--cc=samitolvanen@google.com \
--cc=smueller@chronox.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).