From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Jarkko Sakkinen" <jarkko@kernel.org>,
"Eric Biggers" <ebiggers@kernel.org>, <keyrings@vger.kernel.org>,
<linux-crypto@vger.kernel.org>
Cc: <stable@vger.kernel.org>
Subject: Re: [PATCH] KEYS: asymmetric: Add missing dependency on CRYPTO_SIG
Date: Wed, 24 Apr 2024 00:51:09 +0300 [thread overview]
Message-ID: <D0RU24TWLNT0.2HVLT6RMIU5YT@kernel.org> (raw)
In-Reply-To: <D0RU10Q41UA3.XC5J8UBJUEM4@kernel.org>
On Wed Apr 24, 2024 at 12:49 AM EEST, Jarkko Sakkinen wrote:
> On Tue Apr 23, 2024 at 12:08 AM EEST, Eric Biggers wrote:
> > From: Eric Biggers <ebiggers@google.com>
> >
> > Make ASYMMETRIC_PUBLIC_KEY_SUBTYPE select CRYPTO_SIG to avoid build
> > errors like the following, which were possible with
> > CONFIG_ASYMMETRIC_PUBLIC_KEY_SUBTYPE=y && CONFIG_CRYPTO_SIG=n:
> >
> > ld: vmlinux.o: in function `public_key_verify_signature':
> > (.text+0x306280): undefined reference to `crypto_alloc_sig'
> > ld: (.text+0x306300): undefined reference to `crypto_sig_set_pubkey'
> > ld: (.text+0x306324): undefined reference to `crypto_sig_verify'
> > ld: (.text+0x30636c): undefined reference to `crypto_sig_set_privkey'
> >
> > Fixes: 63ba4d67594a ("KEYS: asymmetric: Use new crypto interface without scatterlists")
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Eric Biggers <ebiggers@google.com>
> > ---
> > crypto/asymmetric_keys/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/crypto/asymmetric_keys/Kconfig b/crypto/asymmetric_keys/Kconfig
> > index 59ec726b7c77..3f089abd6fc9 100644
> > --- a/crypto/asymmetric_keys/Kconfig
> > +++ b/crypto/asymmetric_keys/Kconfig
> > @@ -13,10 +13,11 @@ if ASYMMETRIC_KEY_TYPE
> > config ASYMMETRIC_PUBLIC_KEY_SUBTYPE
> > tristate "Asymmetric public-key crypto algorithm subtype"
> > select MPILIB
> > select CRYPTO_HASH_INFO
> > select CRYPTO_AKCIPHER
> > + select CRYPTO_SIG
> > select CRYPTO_HASH
> > help
> > This option provides support for asymmetric public key type handling.
> > If signature generation and/or verification are to be used,
> > appropriate hash algorithms (such as SHA-1) must be available.
> >
> > base-commit: ed30a4a51bb196781c8058073ea720133a65596f
>
> Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
>
> BR, Jarkko
Picked.
BR, Jarkko
prev parent reply other threads:[~2024-04-23 21:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 21:08 [PATCH] KEYS: asymmetric: Add missing dependency on CRYPTO_SIG Eric Biggers
2024-04-23 21:49 ` Jarkko Sakkinen
2024-04-23 21:51 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D0RU24TWLNT0.2HVLT6RMIU5YT@kernel.org \
--to=jarkko@kernel.org \
--cc=ebiggers@kernel.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).