From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Sergey Shtylyov" <s.shtylyov@omp.ru>,
"Roman Smirnov" <r.smirnov@omp.ru>,
"David Howells" <dhowells@redhat.com>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
"Andrew Zaborowski" <andrew.zaborowski@intel.com>
Cc: "keyrings@vger.kernel.org" <keyrings@vger.kernel.org>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"lvc-project@linuxtesting.org" <lvc-project@linuxtesting.org>
Subject: Re: [PATCH] KEYS: prevent NULL pointer dereference in find_asymmetric_key()
Date: Tue, 10 Sep 2024 15:20:15 +0300 [thread overview]
Message-ID: <D42LLAG1FKOD.2YY4RR8WXSDXO@kernel.org> (raw)
In-Reply-To: <2ba02cfc-b866-bda4-4996-f7f95148832c@omp.ru>
On Mon Sep 9, 2024 at 9:25 PM EEST, Sergey Shtylyov wrote:
> Hello!
>
> Sorry for (so long!) delay -- we're trying to finalize the status
> of our yet unmerged patches...
>
> On 3/21/24 7:12 PM, Jarkko Sakkinen wrote:
> [...]
>
> >>>>>> Found by Linux Verification Center (linuxtesting.org) with Svace.
> >>>>>
> >>>>> I'm not sure if this should be part of the commit message.
> >>>>
> >>>> I have already submitted patches with this line, some have been
> >>>> accepted. It is important for the Linux Verification Center to mark
> >>>> patches as closing issues found with Svace.
> >>>>
> >>>>>>
> >>>>>> Fixes: 7d30198ee24f ("keys: X.509 public key issuer lookup without AKID")
> >>>>>> Suggested-by: Sergey Shtylyov <s.shtylyov@omp.ru>
> >>>>>
> >>>>> Should be reported-by.
> >>>>
> >>>> The suggested-by tag belongs to Sergey because he suggested the fix,
> >>>> subject/description of the patch. The tag reported-by belongs to
> >>>> Svace tool.
> >>>
> >>> 1. I did not see any reported-by tags in this which is requirement.
> >>> 2. Who did find the issue using that tool? I don't put reported-by to
> >>> GDB even if I use that find the bug.
> >>
> >> Svace is an automated bug finding tool. This error was found during
> >> source code analysis by the program, so the tag reported-by does not
q >> belong to any person. I don't know what to do in such a situation,
> >> but write something like:
> >>
> >> Reported-by: Svace
> >>
> >> would be weird. I think that the line "Found by Linux ... with Svace"
> >> could be a substitute for the tag.
> >
> > I'd prefer a person here that used the tool as it is not korg hosted
> > automated tool.
>
> It's a long ago established practice with the Linux Verification Center (http://linuxtesting.org): you can find 700+ merged patches with a similar
> line (mentioning the LVC's website) and without the Reported-by tag:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/log/?qt=grep&q=linuxtesting.org
I see examples alike of
"Found by Linux Verification Center (linuxtesting.org) with Syzkaller."
It neither has an email address, meaning that reported-by tag even has
incorrect format.
NAK, because "Svace" means nothing to me as it is in the tag.
BR, Jarkko
next prev parent reply other threads:[~2024-09-10 12:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-15 10:33 [PATCH] KEYS: prevent NULL pointer dereference in find_asymmetric_key() Roman Smirnov
2024-03-18 23:39 ` Jarkko Sakkinen
2024-03-19 14:44 ` Roman Smirnov
2024-03-19 20:14 ` Jarkko Sakkinen
2024-03-20 8:21 ` Roman Smirnov
2024-03-21 16:12 ` Jarkko Sakkinen
2024-09-09 18:25 ` Sergey Shtylyov
2024-09-10 12:20 ` Jarkko Sakkinen [this message]
2024-09-09 18:51 ` Sergey Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D42LLAG1FKOD.2YY4RR8WXSDXO@kernel.org \
--to=jarkko@kernel.org \
--cc=andrew.zaborowski@intel.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=r.smirnov@omp.ru \
--cc=s.shtylyov@omp.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).