From: Jarkko Sakkinen <jarkko@kernel.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org, David Howells <dhowells@redhat.com>,
keyrings@vger.kernel.org, linux-security-module@vger.kernel.org,
Paul Moore <paul@paul-moore.com>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>
Subject: Re: [PATCH] security: keys: use menuconfig for KEYS symbol
Date: Tue, 26 Aug 2025 01:50:31 +0300 [thread overview]
Message-ID: <aKzot67f7F3wtHs7@kernel.org> (raw)
In-Reply-To: <20250824222813.92300-1-rdunlap@infradead.org>
On Sun, Aug 24, 2025 at 03:28:13PM -0700, Randy Dunlap wrote:
> Give the KEYS kconfig symbol and its associated symbols a separate
> menu space under Security options by using "menuconfig" instead of
> "config".
>
> This also makes it easier to find the security and LSM options.
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> Cc: David Howells <dhowells@redhat.com>
> Cc: Jarkko Sakkinen <jarkko@kernel.org>
> Cc: keyrings@vger.kernel.org
> Cc: linux-security-module@vger.kernel.org
> Cc: Paul Moore <paul@paul-moore.com>
> Cc: James Morris <jmorris@namei.org>
> Cc: "Serge E. Hallyn" <serge@hallyn.com>
>
> security/keys/Kconfig | 14 ++++++--------
> 1 file changed, 6 insertions(+), 8 deletions(-)
>
> --- linux-next-20250819.orig/security/keys/Kconfig
> +++ linux-next-20250819/security/keys/Kconfig
> @@ -3,7 +3,7 @@
> # Key management configuration
> #
>
> -config KEYS
> +menuconfig KEYS
> bool "Enable access key retention support"
> select ASSOCIATIVE_ARRAY
> help
> @@ -21,9 +21,10 @@ config KEYS
>
> If you are unsure as to whether this is required, answer N.
>
> +if KEYS
> +
> config KEYS_REQUEST_CACHE
> bool "Enable temporary caching of the last request_key() result"
> - depends on KEYS
> help
> This option causes the result of the last successful request_key()
> call that didn't upcall to the kernel to be cached temporarily in the
> @@ -41,7 +42,6 @@ config KEYS_REQUEST_CACHE
>
> config PERSISTENT_KEYRINGS
> bool "Enable register of persistent per-UID keyrings"
> - depends on KEYS
> help
> This option provides a register of persistent per-UID keyrings,
> primarily aimed at Kerberos key storage. The keyrings are persistent
> @@ -58,7 +58,6 @@ config PERSISTENT_KEYRINGS
>
> config BIG_KEYS
> bool "Large payload keys"
> - depends on KEYS
> depends on TMPFS
> select CRYPTO_LIB_CHACHA20POLY1305
> help
> @@ -70,7 +69,6 @@ config BIG_KEYS
>
> config TRUSTED_KEYS
> tristate "TRUSTED KEYS"
> - depends on KEYS
> help
> This option provides support for creating, sealing, and unsealing
> keys in the kernel. Trusted keys are random number symmetric keys,
> @@ -85,7 +83,6 @@ endif
>
> config ENCRYPTED_KEYS
> tristate "ENCRYPTED KEYS"
> - depends on KEYS
> select CRYPTO
> select CRYPTO_HMAC
> select CRYPTO_AES
> @@ -114,7 +111,6 @@ config USER_DECRYPTED_DATA
>
> config KEY_DH_OPERATIONS
> bool "Diffie-Hellman operations on retained keys"
> - depends on KEYS
> select CRYPTO
> select CRYPTO_KDF800108_CTR
> select CRYPTO_DH
> @@ -127,9 +123,11 @@ config KEY_DH_OPERATIONS
>
> config KEY_NOTIFICATIONS
> bool "Provide key/keyring change notifications"
> - depends on KEYS && WATCH_QUEUE
> + depends on WATCH_QUEUE
> help
> This option provides support for getting change notifications
> on keys and keyrings on which the caller has View permission.
> This makes use of pipes to handle the notification buffer and
> provides KEYCTL_WATCH_KEY to enable/disable watches.
> +
> +endif # KEYS
I wote for this at least. Definitely an improvement:
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
BR, Jarkko
next prev parent reply other threads:[~2025-08-25 22:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-24 22:28 [PATCH] security: keys: use menuconfig for KEYS symbol Randy Dunlap
2025-08-25 22:50 ` Jarkko Sakkinen [this message]
2025-09-11 20:34 ` Paul Moore
2025-09-14 17:14 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aKzot67f7F3wtHs7@kernel.org \
--to=jarkko@kernel.org \
--cc=dhowells@redhat.com \
--cc=jmorris@namei.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=rdunlap@infradead.org \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).