From: Jarkko Sakkinen <jarkko@kernel.org>
To: Thorsten Blum <thorsten.blum@linux.dev>
Cc: David Howells <dhowells@redhat.com>,
keyrings@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] keys: Fix typos in 'struct key_type' function pointer comments
Date: Mon, 27 Oct 2025 22:11:07 +0200 [thread overview]
Message-ID: <aP_R2ycWjzRWEV8V@kernel.org> (raw)
In-Reply-To: <E9856573-8D4D-4392-9AE5-5D40D1FC13F9@linux.dev>
On Fri, Oct 24, 2025 at 10:29:57PM +0200, Thorsten Blum wrote:
> On 24. Oct 2025, at 21:04, Jarkko Sakkinen wrote:
> > On Thu, Oct 16, 2025 at 02:36:19PM +0200, Thorsten Blum wrote:
> >> s/it/if/ and s/revokation/revocation/
> >> ...
> >
> > The comment is also formatted incorrectly. It should be:
> >
> > /*
> > * Free preparsed match data (optional). This should be supplied if
> > * ->match_preparse() is supplied.
> > */
>
> The other struct fields are all commented with the first sentence
> starting after the '/*'.
>
> I can fix this one trailing '*/' in v2, but the others should probably
> be fixed in a separate patch?
We don't want to batch update to all comments in this file as that e.g.
has more drawbacks than benefits because it increases the probability
of merge conflicts during backports.
I.e.
1. Refine the patch to address the remark that were anyhow modified.
2. Don't update any other comments just for the remark I did.
>
> Thanks,
> Thorsten
>
BR, Jarkko
prev parent reply other threads:[~2025-10-27 20:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-16 12:36 [PATCH] keys: Fix typos in 'struct key_type' function pointer comments Thorsten Blum
2025-10-24 19:04 ` Jarkko Sakkinen
2025-10-24 20:29 ` Thorsten Blum
2025-10-27 20:11 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aP_R2ycWjzRWEV8V@kernel.org \
--to=jarkko@kernel.org \
--cc=dhowells@redhat.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thorsten.blum@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).