From: Casey Schaufler <casey@schaufler-ca.com>
To: Roberto Sassu <roberto.sassu@huaweicloud.com>,
viro@zeniv.linux.org.uk, brauner@kernel.org,
chuck.lever@oracle.com, jlayton@kernel.org, neilb@suse.de,
kolga@netapp.com, Dai.Ngo@oracle.com, tom@talpey.com,
paul@paul-moore.com, jmorris@namei.org, serge@hallyn.com,
zohar@linux.ibm.com, dmitry.kasatkin@gmail.com,
dhowells@redhat.com, jarkko@kernel.org,
stephen.smalley.work@gmail.com, eparis@parisplace.org,
mic@digikod.net
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-nfs@vger.kernel.org, linux-security-module@vger.kernel.org,
linux-integrity@vger.kernel.org, keyrings@vger.kernel.org,
selinux@vger.kernel.org, Roberto Sassu <roberto.sassu@huawei.com>,
Stefan Berger <stefanb@linux.ibm.com>,
Casey Schaufler <casey@schaufler-ca.com>
Subject: Re: [PATCH v5 18/23] security: Introduce key_post_create_or_update hook
Date: Tue, 7 Nov 2023 09:47:22 -0800 [thread overview]
Message-ID: <d32add2c-26ed-4988-990b-3014d7727645@schaufler-ca.com> (raw)
In-Reply-To: <20231107134012.682009-19-roberto.sassu@huaweicloud.com>
On 11/7/2023 5:40 AM, Roberto Sassu wrote:
> From: Roberto Sassu <roberto.sassu@huawei.com>
>
> In preparation for moving IMA and EVM to the LSM infrastructure, introduce
> the key_post_create_or_update hook.
>
> Depending on policy, IMA measures the key content after creation or update,
> so that remote verifiers are aware of the operation.
>
> Other LSMs could similarly take some action after successful key creation
> or update.
>
> The new hook cannot return an error and cannot cause the operation to be
> reverted.
>
> Signed-off-by: Roberto Sassu <roberto.sassu@huawei.com>
> Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>
Acked-by: Casey Schaufler <casey@schaufler-ca.com>
> ---
> include/linux/lsm_hook_defs.h | 3 +++
> include/linux/security.h | 11 +++++++++++
> security/keys/key.c | 7 ++++++-
> security/security.c | 19 +++++++++++++++++++
> 4 files changed, 39 insertions(+), 1 deletion(-)
>
> diff --git a/include/linux/lsm_hook_defs.h b/include/linux/lsm_hook_defs.h
> index 2bf128f7cbae..ec5d160c32ba 100644
> --- a/include/linux/lsm_hook_defs.h
> +++ b/include/linux/lsm_hook_defs.h
> @@ -403,6 +403,9 @@ LSM_HOOK(void, LSM_RET_VOID, key_free, struct key *key)
> LSM_HOOK(int, 0, key_permission, key_ref_t key_ref, const struct cred *cred,
> enum key_need_perm need_perm)
> LSM_HOOK(int, 0, key_getsecurity, struct key *key, char **buffer)
> +LSM_HOOK(void, LSM_RET_VOID, key_post_create_or_update, struct key *keyring,
> + struct key *key, const void *payload, size_t payload_len,
> + unsigned long flags, bool create)
> #endif /* CONFIG_KEYS */
>
> #ifdef CONFIG_AUDIT
> diff --git a/include/linux/security.h b/include/linux/security.h
> index 7cd7126f6545..1cd84970ab4c 100644
> --- a/include/linux/security.h
> +++ b/include/linux/security.h
> @@ -1995,6 +1995,9 @@ void security_key_free(struct key *key);
> int security_key_permission(key_ref_t key_ref, const struct cred *cred,
> enum key_need_perm need_perm);
> int security_key_getsecurity(struct key *key, char **_buffer);
> +void security_key_post_create_or_update(struct key *keyring, struct key *key,
> + const void *payload, size_t payload_len,
> + unsigned long flags, bool create);
>
> #else
>
> @@ -2022,6 +2025,14 @@ static inline int security_key_getsecurity(struct key *key, char **_buffer)
> return 0;
> }
>
> +static inline void security_key_post_create_or_update(struct key *keyring,
> + struct key *key,
> + const void *payload,
> + size_t payload_len,
> + unsigned long flags,
> + bool create)
> +{ }
> +
> #endif
> #endif /* CONFIG_KEYS */
>
> diff --git a/security/keys/key.c b/security/keys/key.c
> index 0260a1902922..f75fe66c2f03 100644
> --- a/security/keys/key.c
> +++ b/security/keys/key.c
> @@ -935,6 +935,8 @@ static key_ref_t __key_create_or_update(key_ref_t keyring_ref,
> goto error_link_end;
> }
>
> + security_key_post_create_or_update(keyring, key, payload, plen, flags,
> + true);
> ima_post_key_create_or_update(keyring, key, payload, plen,
> flags, true);
>
> @@ -968,10 +970,13 @@ static key_ref_t __key_create_or_update(key_ref_t keyring_ref,
>
> key_ref = __key_update(key_ref, &prep);
>
> - if (!IS_ERR(key_ref))
> + if (!IS_ERR(key_ref)) {
> + security_key_post_create_or_update(keyring, key, payload, plen,
> + flags, false);
> ima_post_key_create_or_update(keyring, key,
> payload, plen,
> flags, false);
> + }
>
> goto error_free_prep;
> }
> diff --git a/security/security.c b/security/security.c
> index 6eb7c9cff1e5..859189722ab8 100644
> --- a/security/security.c
> +++ b/security/security.c
> @@ -5406,6 +5406,25 @@ int security_key_getsecurity(struct key *key, char **buffer)
> *buffer = NULL;
> return call_int_hook(key_getsecurity, 0, key, buffer);
> }
> +
> +/**
> + * security_key_post_create_or_update() - Notification of key create or update
> + * @keyring: keyring to which the key is linked to
> + * @key: created or updated key
> + * @payload: data used to instantiate or update the key
> + * @payload_len: length of payload
> + * @flags: key flags
> + * @create: flag indicating whether the key was created or updated
> + *
> + * Notify the caller of a key creation or update.
> + */
> +void security_key_post_create_or_update(struct key *keyring, struct key *key,
> + const void *payload, size_t payload_len,
> + unsigned long flags, bool create)
> +{
> + call_void_hook(key_post_create_or_update, keyring, key, payload,
> + payload_len, flags, create);
> +}
> #endif /* CONFIG_KEYS */
>
> #ifdef CONFIG_AUDIT
next prev parent reply other threads:[~2023-11-07 17:47 UTC|newest]
Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-07 13:39 [PATCH v5 00/23] security: Move IMA and EVM to the LSM infrastructure Roberto Sassu
2023-11-07 13:39 ` [PATCH v5 01/23] ima: Align ima_inode_post_setattr() definition with " Roberto Sassu
2023-11-07 17:21 ` Casey Schaufler
2023-11-07 13:39 ` [PATCH v5 02/23] ima: Align ima_file_mprotect() " Roberto Sassu
2023-11-07 17:22 ` Casey Schaufler
2023-11-07 13:39 ` [PATCH v5 03/23] ima: Align ima_inode_setxattr() " Roberto Sassu
2023-11-07 17:23 ` Casey Schaufler
2023-11-07 13:39 ` [PATCH v5 04/23] ima: Align ima_inode_removexattr() " Roberto Sassu
2023-11-07 17:24 ` Casey Schaufler
2023-11-07 13:39 ` [PATCH v5 05/23] ima: Align ima_post_read_file() " Roberto Sassu
2023-11-07 17:25 ` Casey Schaufler
2023-11-07 13:39 ` [PATCH v5 06/23] evm: Align evm_inode_post_setattr() " Roberto Sassu
2023-11-07 17:26 ` Casey Schaufler
2023-11-07 13:39 ` [PATCH v5 07/23] evm: Align evm_inode_setxattr() " Roberto Sassu
2023-11-07 17:27 ` Casey Schaufler
2023-11-07 13:39 ` [PATCH v5 08/23] evm: Align evm_inode_post_setxattr() " Roberto Sassu
2023-11-07 17:28 ` Casey Schaufler
2023-11-07 13:39 ` [PATCH v5 09/23] security: Align inode_setattr hook definition with EVM Roberto Sassu
2023-11-07 13:39 ` [PATCH v5 10/23] security: Introduce inode_post_setattr hook Roberto Sassu
2023-11-07 17:30 ` Casey Schaufler
2023-11-16 4:33 ` Paul Moore
2023-11-16 9:43 ` Roberto Sassu
2023-11-16 18:46 ` Paul Moore
2023-11-07 13:40 ` [PATCH v5 11/23] security: Introduce inode_post_removexattr hook Roberto Sassu
2023-11-07 17:33 ` Casey Schaufler
2023-11-07 17:45 ` Roberto Sassu
2023-11-20 17:31 ` Roberto Sassu
2023-11-20 18:03 ` Casey Schaufler
2023-11-20 20:55 ` Paul Moore
2023-11-16 4:33 ` Paul Moore
2023-11-07 13:40 ` [PATCH v5 12/23] security: Introduce file_post_open hook Roberto Sassu
2023-11-07 17:35 ` Casey Schaufler
2023-11-07 13:40 ` [PATCH v5 13/23] security: Introduce file_pre_free_security hook Roberto Sassu
2023-11-07 17:39 ` Casey Schaufler
2023-11-16 4:33 ` Paul Moore
2023-11-16 9:46 ` Roberto Sassu
2023-11-16 18:41 ` Paul Moore
2023-11-07 13:40 ` [PATCH v5 14/23] security: Introduce path_post_mknod hook Roberto Sassu
2023-11-07 17:41 ` Casey Schaufler
2023-11-07 13:40 ` [PATCH v5 15/23] security: Introduce inode_post_create_tmpfile hook Roberto Sassu
2023-11-07 17:42 ` Casey Schaufler
2023-11-16 4:33 ` Paul Moore
2023-11-07 13:40 ` [PATCH v5 16/23] security: Introduce inode_post_set_acl hook Roberto Sassu
2023-11-07 17:44 ` Casey Schaufler
2023-11-16 4:33 ` Paul Moore
2023-11-07 13:40 ` [PATCH v5 17/23] security: Introduce inode_post_remove_acl hook Roberto Sassu
2023-11-07 17:45 ` Casey Schaufler
2023-11-16 4:33 ` Paul Moore
2023-11-07 13:40 ` [PATCH v5 18/23] security: Introduce key_post_create_or_update hook Roberto Sassu
2023-11-07 17:47 ` Casey Schaufler [this message]
2023-11-07 13:40 ` [PATCH v5 19/23] ima: Move to LSM infrastructure Roberto Sassu
2023-11-07 17:52 ` Casey Schaufler
2023-11-07 13:40 ` [PATCH v5 20/23] ima: Move IMA-Appraisal " Roberto Sassu
2023-11-07 18:43 ` Casey Schaufler
2023-11-07 13:40 ` [PATCH v5 21/23] evm: Move " Roberto Sassu
2023-11-07 18:45 ` Casey Schaufler
2023-11-07 13:40 ` [PATCH v5 22/23] integrity: Move integrity functions to the " Roberto Sassu
2023-11-07 18:46 ` Casey Schaufler
2023-11-16 4:33 ` Paul Moore
2023-11-16 10:07 ` Roberto Sassu
2023-11-17 21:22 ` Paul Moore
2023-11-20 13:23 ` Roberto Sassu
2023-11-07 13:40 ` [PATCH v5 23/23] integrity: Switch from rbtree to LSM-managed blob for integrity_iint_cache Roberto Sassu
2023-11-17 20:57 ` Paul Moore
2023-11-20 8:16 ` Roberto Sassu
2023-11-20 21:06 ` Paul Moore
2023-11-29 12:27 ` Roberto Sassu
2023-11-29 13:58 ` Roberto Sassu
2023-11-29 17:22 ` Paul Moore
2023-11-29 18:46 ` Roberto Sassu
2023-11-30 0:41 ` Casey Schaufler
2023-11-30 8:30 ` Petr Tesarik
2023-11-30 16:15 ` Casey Schaufler
2023-11-30 21:34 ` Roberto Sassu
2023-11-30 23:31 ` Casey Schaufler
2023-11-30 23:43 ` Roberto Sassu
2023-12-01 0:12 ` Casey Schaufler
2023-11-30 11:12 ` Mimi Zohar
2023-11-30 16:59 ` Paul Moore
2023-11-30 17:00 ` Paul Moore
2023-11-30 16:34 ` Paul Moore
2023-11-30 21:56 ` Roberto Sassu
2023-12-04 13:26 ` Roberto Sassu
2023-12-04 15:01 ` Mimi Zohar
2023-12-06 13:10 ` Roberto Sassu
2023-12-06 16:11 ` Mimi Zohar
2023-12-06 16:50 ` Roberto Sassu
2023-12-01 1:05 ` Dr. Greg
2023-12-01 18:54 ` Casey Schaufler
2023-12-01 23:53 ` Dr. Greg
2023-12-02 0:17 ` Casey Schaufler
2023-12-13 10:45 ` Roberto Sassu
2023-12-13 18:08 ` Casey Schaufler
2023-11-07 14:05 ` [PATCH v5 00/23] security: Move IMA and EVM to the LSM infrastructure Roberto Sassu
2023-11-07 19:37 ` Mimi Zohar
2023-11-08 3:14 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d32add2c-26ed-4988-990b-3014d7727645@schaufler-ca.com \
--to=casey@schaufler-ca.com \
--cc=Dai.Ngo@oracle.com \
--cc=brauner@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=dhowells@redhat.com \
--cc=dmitry.kasatkin@gmail.com \
--cc=eparis@parisplace.org \
--cc=jarkko@kernel.org \
--cc=jlayton@kernel.org \
--cc=jmorris@namei.org \
--cc=keyrings@vger.kernel.org \
--cc=kolga@netapp.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mic@digikod.net \
--cc=neilb@suse.de \
--cc=paul@paul-moore.com \
--cc=roberto.sassu@huawei.com \
--cc=roberto.sassu@huaweicloud.com \
--cc=selinux@vger.kernel.org \
--cc=serge@hallyn.com \
--cc=stefanb@linux.ibm.com \
--cc=stephen.smalley.work@gmail.com \
--cc=tom@talpey.com \
--cc=viro@zeniv.linux.org.uk \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).