Linux Kernel Summit discussions
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Eduardo Valentin <edubezval@gmail.com>
Cc: ksummit <ksummit-discuss@lists.linuxfoundation.org>
Subject: Re: [Ksummit-discuss] [MAINTAINERS SUMMIT] Bug-introducing patches
Date: Tue, 11 Sep 2018 10:49:20 +1000	[thread overview]
Message-ID: <20180911104920.10579e62@canb.auug.org.au> (raw)
In-Reply-To: <20180910230301.GB1764@localhost.localdomain>

[-- Attachment #1: Type: text/plain, Size: 2284 bytes --]

Hi Eduardo,

On Mon, 10 Sep 2018 16:03:03 -0700 Eduardo Valentin <edubezval@gmail.com> wrote:
>
> On Mon, Sep 10, 2018 at 05:46:38PM -0400, Steven Rostedt wrote:
> > Honestly, I think this is something that Linus should yell at
> > maintainers for. I treat my pushes into linux-next the same as I treat
> > my pull requests to Linus. I don't push anything into next until it's
> > been fully run through my test suite, and passes. That also makes it
> > easier for me to know that whatever I have in next is also ready for
> > Linus (the way it was suppose to be).  
> 
> Shouldn't we all be doing that?

Yes.

> > With the 0day bot, I think it's become much better. But honestly, I
> > think any branch that causes next to fail to build, or run basic tests,
> > should be taken out of linux-next and a nasty message sent to the
> > guilty maintainer. With the exception that a breakage was caused by two
> > conflicting commits (for example, one that changes an API, and another
> > branch that uses that API without the update). Those types of breakages
> > is what linux-next is made for. But if the branch being pulled into
> > linux-next breaks something without the integration, then that's
> > unacceptable.  
> 
> I thought that was the case already, everthing that goes to linux-next
> is ready to go to Linus.

And, again, yes.

This is what I tell every maintainer that adds a tree to linux-next:

"Thanks for adding your subsystem tree as a participant of linux-next.  As
you may know, this is not a judgement of your code.  The purpose of
linux-next is for integration testing and to lower the impact of
conflicts between subsystems in the next merge window. 

You will need to ensure that the patches/commits in your tree/series have
been:
     * submitted under GPL v2 (or later) and include the Contributor's
        Signed-off-by,
     * posted to the relevant mailing list,
     * reviewed by you (or another maintainer of your subsystem tree),
     * successfully unit tested, and 
     * destined for the current or next Linux merge window.

Basically, this should be just what you would send to Linus (or ask him
to fetch).  It is allowed to be rebased if you deem it necessary."

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  parent reply	other threads:[~2018-09-11  0:49 UTC|newest]

Thread overview: 138+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-04 20:16 [Ksummit-discuss] [MAINTAINERS SUMMIT] Bug-introducing patches Sasha Levin
2018-09-04 20:53 ` Daniel Vetter
2018-09-05 14:17   ` Steven Rostedt
2018-09-07  0:51     ` Sasha Levin
2018-09-07  1:09       ` Steven Rostedt
2018-09-07 20:12         ` Greg KH
2018-09-07 21:12           ` Greg KH
2018-09-07  1:09       ` Linus Torvalds
2018-09-07  1:49         ` Sasha Levin
2018-09-07  2:31           ` Linus Torvalds
2018-09-07  2:45             ` Steven Rostedt
2018-09-07  3:43               ` Linus Torvalds
2018-09-07  8:52                 ` Daniel Vetter
2018-09-07  8:40               ` Geert Uytterhoeven
2018-09-07  9:07                 ` Daniel Vetter
2018-09-07  9:28                   ` Geert Uytterhoeven
2018-09-07 17:05                   ` Olof Johansson
2018-09-07 14:54             ` Sasha Levin
2018-09-07 15:52               ` Linus Torvalds
2018-09-07 16:17                 ` Linus Torvalds
2018-09-07 21:39                   ` Mauro Carvalho Chehab
2018-09-09 12:50                   ` Stephen Rothwell
2018-09-10 20:05                     ` Tony Lindgren
2018-09-10 19:43                 ` Sasha Levin
2018-09-10 20:45                   ` Steven Rostedt
2018-09-10 21:20                     ` Guenter Roeck
2018-09-10 21:46                       ` Steven Rostedt
2018-09-10 23:03                         ` Eduardo Valentin
2018-09-10 23:13                           ` Steven Rostedt
2018-09-11 15:42                             ` Steven Rostedt
2018-09-11 17:40                               ` Tony Lindgren
2018-09-11 17:47                                 ` James Bottomley
2018-09-11 18:12                                   ` Eduardo Valentin
2018-09-11 18:17                                     ` Geert Uytterhoeven
2018-09-12 15:15                                       ` Eduardo Valentin
2018-09-11 18:19                                     ` James Bottomley
2018-09-12 15:17                                       ` Eduardo Valentin
2018-09-11 18:39                                   ` Steven Rostedt
2018-09-11 20:09                                     ` James Bottomley
2018-09-11 20:31                                       ` Steven Rostedt
2018-09-11 22:53                                         ` James Bottomley
2018-09-11 23:04                                           ` Sasha Levin
2018-09-11 23:11                                             ` James Bottomley
2018-09-11 23:20                                               ` Sasha Levin
2018-09-12 15:41                                                 ` Eduardo Valentin
2018-09-11 23:22                                           ` Tony Lindgren
2018-09-11 23:29                                             ` James Bottomley
2018-09-12 11:55                                               ` Geert Uytterhoeven
2018-09-12 12:03                                                 ` Laurent Pinchart
2018-09-12 12:29                                                   ` Thomas Gleixner
2018-09-12 12:53                                                     ` Laurent Pinchart
2018-09-12 13:10                                                       ` Alexandre Belloni
2018-09-12 13:30                                                         ` Thomas Gleixner
2018-09-12 23:16                                                         ` Laurent Pinchart
2018-09-12 14:11                                                       ` Thomas Gleixner
2018-09-19  8:26                                                         ` Laurent Pinchart
2018-09-20  9:02                                                           ` Rafael J. Wysocki
2018-09-20 10:10                                                             ` Laurent Pinchart
2018-09-20 11:00                                                               ` Daniel Vetter
2018-09-20 11:08                                                                 ` Laurent Pinchart
2018-09-20 11:49                                                                   ` Daniel Vetter
2018-09-12 12:36                                                 ` James Bottomley
2018-09-12 13:38                                                   ` Guenter Roeck
2018-09-12 13:59                                                     ` Tony Lindgren
2018-09-12 10:04                                             ` Mark Brown
2018-09-12 20:24                                           ` Steven Rostedt
2018-09-12 20:29                                             ` Sasha Levin
2018-09-13  0:19                                             ` Stephen Rothwell
2018-09-13 11:39                                               ` Mark Brown
2018-09-19  6:27                                                 ` Stephen Rothwell
2018-09-19 17:24                                                   ` Mark Brown
2018-09-19 21:42                                                     ` Stephen Rothwell
2018-09-11  0:49                           ` Stephen Rothwell [this message]
2018-09-11  1:01                             ` Al Viro
2018-09-11  0:47                         ` Stephen Rothwell
2018-09-11 17:35                           ` Linus Torvalds
2018-09-11  0:43                       ` Stephen Rothwell
2018-09-11 16:49                         ` Guenter Roeck
2018-09-11 17:47                           ` Guenter Roeck
2018-09-11 11:18                       ` Mark Brown
2018-09-11 17:02                         ` Guenter Roeck
2018-09-11 17:12                           ` Jani Nikula
2018-09-11 17:31                             ` Mark Brown
2018-09-11 17:41                               ` Daniel Vetter
2018-09-11 18:54                                 ` Mark Brown
2018-09-11 18:03                             ` Geert Uytterhoeven
2018-09-11 17:22                           ` James Bottomley
2018-09-11 17:56                             ` Mark Brown
2018-09-11 18:00                               ` James Bottomley
2018-09-11 18:16                                 ` Mark Brown
2018-09-11 18:07                             ` Geert Uytterhoeven
2018-09-12  9:09                             ` Dan Carpenter
2018-09-11 17:26                           ` Mark Brown
2018-09-11 18:45                           ` Steven Rostedt
2018-09-11 18:57                             ` Daniel Vetter
2018-09-11 20:15                               ` Thomas Gleixner
2018-09-12  9:03                           ` Dan Carpenter
2018-09-10 23:01                     ` Eduardo Valentin
2018-09-10 23:12                       ` Steven Rostedt
2018-09-10 23:32                         ` Eduardo Valentin
2018-09-10 23:38                           ` Guenter Roeck
2018-09-10 23:38                     ` Sasha Levin
2018-09-07  2:33           ` Steven Rostedt
2018-09-07  2:52           ` Guenter Roeck
2018-09-07 14:37             ` Laura Abbott
2018-09-07 15:06               ` Sasha Levin
2018-09-07 15:54                 ` Laura Abbott
2018-09-07 16:09                   ` Sasha Levin
2018-09-07 20:23                     ` Greg KH
2018-09-07 21:13                       ` Sasha Levin
2018-09-07 22:27                         ` Linus Torvalds
2018-09-07 22:43                           ` Guenter Roeck
2018-09-07 22:53                             ` Linus Torvalds
2018-09-07 22:57                               ` Sasha Levin
2018-09-07 23:52                                 ` Guenter Roeck
2018-09-08 16:33                                 ` Greg Kroah-Hartman
2018-09-08 18:35                                   ` Guenter Roeck
2018-09-10 13:47                                     ` Mark Brown
2018-09-09  4:36                                   ` Sasha Levin
2018-09-10 16:20                             ` Dan Rue
2018-09-07 21:32                 ` Dan Carpenter
2018-09-07 21:43                   ` Sasha Levin
2018-09-08 13:20                     ` Dan Carpenter
2018-09-10  8:23                     ` Jan Kara
2018-09-10  7:53                   ` Jan Kara
2018-09-07  3:38           ` Al Viro
2018-09-07  4:27           ` Theodore Y. Ts'o
2018-09-07  5:45             ` Stephen Rothwell
2018-09-07  9:13             ` Daniel Vetter
2018-09-07 11:32               ` Mark Brown
2018-09-07 21:06               ` Mauro Carvalho Chehab
2018-09-08  9:44                 ` Laurent Pinchart
2018-09-08 11:48                   ` Mauro Carvalho Chehab
2018-09-09 14:26                     ` Laurent Pinchart
2018-09-10 22:14                       ` Eduardo Valentin
2018-09-07 14:56             ` Sasha Levin
2018-09-07 15:07               ` Jens Axboe
2018-09-07 20:58                 ` Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180911104920.10579e62@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=edubezval@gmail.com \
    --cc=ksummit-discuss@lists.linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).