From: Kees Cook <keescook@chromium.org>
To: Theodore Ts'o <tytso@mit.edu>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
ksummit-discuss@lists.linuxfoundation.org
Subject: Re: [Ksummit-discuss] [MAINTAINERS SUMMIT] Patch version changes in commit logs?
Date: Tue, 2 Jul 2019 16:41:35 -0700 [thread overview]
Message-ID: <201907021638.3D0AC00@keescook> (raw)
In-Reply-To: <20190702231858.GK3032@mit.edu>
On Tue, Jul 02, 2019 at 07:18:58PM -0400, Theodore Ts'o wrote:
> On Tue, Jul 02, 2019 at 04:04:31PM -0700, Kees Cook wrote:
> > > Step 1) git config am.messageid true
> >
> > This is a lossy action: we don't know which list the ID came from (e.g.
> > many things are sent to subsystem lists and not lkml).
>
> Why do we need to care which list the ID came from? Many messages are
> cc'ed to multiple lists that are archived on lore.kernel.org. And it
> doesn't matter:
>
> lore.kernel.org/r/<message-id>
>
> ... will work without needing to know which list it was sent to.
>
> > > Step 2) Write and install a .git/hooks/applypatch-msg script which
> > > looks for Message-Id: and transmogrifies that line to a
> > > Link: trailer, using the lore.kernel.org URL template
> >
> > I think the lorifier.py[1] mentioned earlier has 90% of the "step 2"
> > logic, including caching the lore list mappings. Is there a "git am" hook
> > we could build on instead? /me looks. Yes; seems to be "applypatch-msg"?
> > Unclear if the email headers are included...
>
> applypatch-msg is the git hoook I had suggested above.
>
> The documentation states:
>
> This hook is invoked by git-am[1]. It takes a single parameter,
> the name of the file that holds the proposed commit log
> message. Exiting with a non-zero status causes git am to abort
> before applying the patch.
>
> The hook is allowed to edit the message file in place, and can be
> used to normalize the message into some project standard
> format. It can also be used to refuse the commit after inspecting
> the message file.
>
>
> That to me says the e-mail headers have already been stripped.
> Fortunately, using am.messageid=true should work since that is part of
> the proposed commit message.
This works for me:
$ git config am.messageid true
$ cat >.git/hooks/applypatch-msg <<'EOF'
#!/bin/sh
. git-sh-setup
perl -pi -e 's|^Message-Id:\s*<?([^>]+)>?$|Link: https://lore.kernel.org/r/$1|g;' "$1"
test -x "$GIT_DIR/hooks/commit-msg" &&
exec "$GIT_DIR/hooks/commit-msg" ${1+"$@"}
:
EOF
$ chmod a+x .git/hooks/applypatch-msg
--
Kees Cook
next prev parent reply other threads:[~2019-07-02 23:41 UTC|newest]
Thread overview: 106+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 20:11 [Ksummit-discuss] [MAINTAINERS SUMMIT] Patch version changes in commit logs? Shuah Khan
2019-06-28 20:51 ` Luck, Tony
2019-06-28 21:05 ` Kees Cook
2019-06-28 21:07 ` Shuah Khan
2019-06-28 21:13 ` James Bottomley
2019-06-28 21:42 ` Shuah Khan
2019-06-28 21:07 ` Wolfram Sang
2019-06-29 6:19 ` Thomas Gleixner
2019-06-29 9:10 ` Christian Brauner
2019-06-29 13:43 ` Andrea Parri
2019-06-29 15:16 ` Thomas Gleixner
2019-06-30 16:31 ` Konstantin Ryabitsev
2019-07-01 7:20 ` Peter Zijlstra
2019-07-01 7:49 ` Thomas Gleixner
2019-07-01 7:53 ` Takashi Iwai
2019-07-17 9:23 ` Dan Carpenter
2019-07-17 9:27 ` Dan Carpenter
2019-07-17 9:28 ` Greg KH
2019-07-17 16:09 ` Linus Walleij
2019-07-17 20:44 ` Greg KH
2019-07-18 9:09 ` Linus Walleij
2019-07-22 17:02 ` Kees Cook
2019-07-22 17:12 ` Joe Perches
2019-07-01 17:27 ` Steven Rostedt
2019-07-01 17:55 ` Thomas Gleixner
2019-07-01 9:48 ` Andrea Parri
2019-07-01 9:51 ` Andrea Parri
2019-07-02 4:40 ` Leon Romanovsky
2019-07-02 7:27 ` Geert Uytterhoeven
2019-07-02 9:48 ` Leon Romanovsky
2019-06-29 6:57 ` Takashi Iwai
2019-06-29 7:09 ` Thomas Gleixner
2019-06-29 7:18 ` Takashi Iwai
2019-06-29 11:20 ` Mark Brown
2019-06-30 16:01 ` Mauro Carvalho Chehab
2019-07-01 1:35 ` Andrew Donnellan
2019-07-01 11:10 ` Mark Brown
2019-08-08 5:24 ` Andrew Donnellan
2019-07-01 9:05 ` Jiri Kosina
2019-07-01 9:15 ` Sergey Senozhatsky
2019-07-04 12:15 ` Michael Ellerman
2019-07-04 13:24 ` Geert Uytterhoeven
2019-07-04 14:16 ` Thomas Gleixner
2019-07-05 3:37 ` Michael Ellerman
2019-07-05 4:10 ` Michael Ellerman
2019-07-05 6:28 ` Thomas Gleixner
2019-07-05 8:24 ` Geert Uytterhoeven
2019-07-04 14:22 ` James Bottomley
2019-07-05 3:24 ` Michael Ellerman
2019-07-06 14:02 ` Alexandre Belloni
2019-07-06 14:57 ` James Bottomley
2019-07-05 3:40 ` Michael Ellerman
2019-07-05 8:40 ` Geert Uytterhoeven
2019-06-28 21:07 ` James Bottomley
2019-07-01 15:06 ` David Howells
2019-07-01 15:40 ` Thomas Gleixner
2019-07-01 15:48 ` Laurent Pinchart
2019-07-01 15:50 ` James Bottomley
2019-07-01 17:54 ` Thomas Gleixner
2019-07-02 14:20 ` James Bottomley
2019-07-02 14:49 ` Thomas Gleixner
2019-07-02 15:10 ` James Bottomley
2019-07-02 15:18 ` James Bottomley
2019-07-02 15:39 ` Shuah Khan
2019-07-02 15:51 ` James Bottomley
2019-07-02 16:30 ` Kees Cook
2019-07-02 21:16 ` Konstantin Ryabitsev
2019-07-02 21:33 ` James Bottomley
2019-07-02 22:07 ` Thomas Gleixner
2019-07-02 22:26 ` James Bottomley
2019-07-02 22:43 ` Theodore Ts'o
2019-07-02 22:49 ` Thomas Gleixner
2019-07-03 23:52 ` Ralf Ramsauer
2019-07-02 22:53 ` James Bottomley
2019-07-02 23:12 ` Thomas Gleixner
2019-07-02 23:04 ` Kees Cook
2019-07-02 23:18 ` Theodore Ts'o
2019-07-02 23:31 ` Kees Cook
2019-07-02 23:33 ` James Bottomley
2019-07-03 4:16 ` Theodore Ts'o
2019-07-03 4:50 ` James Bottomley
2019-07-03 14:42 ` Kees Cook
2019-07-02 23:41 ` Kees Cook [this message]
2019-07-03 7:51 ` Greg KH
2019-07-03 8:56 ` Laurent Pinchart
2019-07-03 9:12 ` Thomas Gleixner
2019-07-03 12:39 ` Leon Romanovsky
2019-07-03 22:53 ` Laurent Pinchart
2019-07-03 13:50 ` Theodore Ts'o
2019-07-03 14:10 ` Jan Kara
2019-07-03 17:05 ` Mark Brown
2019-07-03 19:11 ` Frank Rowand
2019-07-05 9:26 ` Linus Walleij
2019-07-05 19:34 ` Mike Rapoport
2019-07-06 4:42 ` Theodore Ts'o
2019-07-07 21:56 ` Frank Rowand
2019-07-03 23:03 ` James Bottomley
2019-07-04 7:10 ` Geert Uytterhoeven
2019-07-05 9:03 ` Linus Walleij
2019-07-02 22:48 ` Thomas Gleixner
2019-07-02 23:05 ` James Bottomley
2019-07-02 19:03 ` Shuah Khan
2019-07-02 15:30 ` Thomas Gleixner
2019-07-02 15:40 ` James Bottomley
2019-07-02 15:49 ` Thomas Gleixner
2019-07-02 20:44 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201907021638.3D0AC00@keescook \
--to=keescook@chromium.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=ksummit-discuss@lists.linuxfoundation.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).