Linux Kernel Summit discussions
 help / color / mirror / Atom feed

From: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: ksummit-discuss@lists.linuxfoundation.org
Subject: Re: [Ksummit-discuss] [MAINTAINERS SUMMIT] Keeping reviews meaningful
Date: Mon, 15 Jul 2019 13:11:36 -0300	[thread overview]
Message-ID: <20190715131136.6ec26015@coco.lan> (raw)
In-Reply-To: <20190706171724.GA12534@kunai>

Em Sat, 6 Jul 2019 19:17:24 +0200
Wolfram Sang <wsa@the-dreams.de> escreveu:

> The "problem" with a new reviewer is that I don't know if all aspects of
> a patch have been reviewed or just a subset. 

That's a good point.

While receiving feedback from some -doc patches I wrote, I guess we
currently have something that we can improve for acked-by/reviewed-by
tag description: how to indicate a partial review/ack?

I received several such acks with things like:

	For driver_foo:

	Acked-by : me <my@email>

I also received such acks as:

	Acked-by : me <my@email> # driver_foo
or:
	Acked-by : me <my@email> # for driver_foo

I guess we could agree on a "syntax" for that, with could be easily
be parsed by scripts, documenting it at
Documentation/process/5.Posting.rst.

I'm in favor of:

	Acked-by : me <my@email> # driver_foo
and:
	Reviewed-by : me <my@email> # driver_foo

Thanks,
Mauro

next prev parent reply	other threads:[~2019-07-15 16:11 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-06 14:27 [Ksummit-discuss] [MAINTAINERS SUMMIT] Keeping reviews meaningful Wolfram Sang
2019-07-06 16:52 ` Leon Romanovsky
2019-07-06 17:17   ` Wolfram Sang
2019-07-08 10:47     ` Jan Kara
2019-07-08 11:47       ` Wolfram Sang
2019-07-15 16:11     ` Mauro Carvalho Chehab [this message]
2019-07-08 11:21 ` Geert Uytterhoeven
2019-07-08 11:59   ` Wolfram Sang
2019-07-15 15:58     ` Mauro Carvalho Chehab
2019-07-15 17:00       ` Theodore Y. Ts'o
2019-07-15 17:11         ` Mauro Carvalho Chehab
2019-07-16 21:26         ` Wolfram Sang
2019-08-17 21:35         ` Paul Walmsley
2019-08-19  6:57           ` Jan Kara
2019-08-19  7:06             ` Jiri Kosina
2019-08-19  7:06             ` Julia Lawall
2019-08-19  8:04               ` Jan Kara
2019-08-19  8:13                 ` Julia Lawall
2019-08-20 10:22                   ` James Bottomley
2019-08-19  8:26             ` Thomas Gleixner
2019-08-19 16:16               ` Christian Brauner
2019-08-19 19:04                 ` Thomas Gleixner
2019-08-19 21:03                   ` Christian Brauner
2019-07-08 14:57   ` Mark Brown
2019-07-14  9:35 ` Jonathan Cameron
2019-07-14 10:13   ` Thomas Gleixner
2019-07-15  9:10     ` Rafael J. Wysocki
2019-07-16 21:16     ` Wolfram Sang
2019-07-16 21:57       ` Olof Johansson
2019-07-16 22:27         ` Thomas Gleixner
2019-07-17  3:59           ` Randy Dunlap
2019-07-17  7:31             ` Wolfram Sang
2019-07-17 16:05               ` Linus Walleij
2019-07-17 16:40                 ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190715131136.6ec26015@coco.lan \
    --to=mchehab+samsung@kernel.org \
    --cc=ksummit-discuss@lists.linuxfoundation.org \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).