From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 6BED8A7F for ; Mon, 19 Aug 2019 06:57:13 +0000 (UTC) Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id CCA2F8A2 for ; Mon, 19 Aug 2019 06:57:12 +0000 (UTC) Date: Mon, 19 Aug 2019 08:57:10 +0200 From: Jan Kara To: Paul Walmsley Message-ID: <20190819065710.GC20455@quack2.suse.cz> References: <20190706142738.GA6893@kunai> <20190708115949.GC1050@kunai> <20190715125800.22a9a979@coco.lan> <20190715170045.GB3068@mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Cc: Mauro Carvalho Chehab , ksummit Subject: Re: [Ksummit-discuss] [MAINTAINERS SUMMIT] Keeping reviews meaningful List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sat 17-08-19 21:35:29, Paul Walmsley wrote: > On Mon, 15 Jul 2019, Theodore Y. Ts'o wrote: > > > I'd suggest changing the text to read: > > > > - Acked-by: indicates an agreement by the maintainer or > > reviewer of the the relevant code that the patch is > > appropriate for inclusion into the kernel. > > This would be a positive step forward. I would be in favor of this. > > It would also be good to state here, if it isn't stated already, that > "reviewer" means "someone who is listed in an R: line in MAINTAINERS". I don't think that 'R:' entry in MAINTAINERS should be really asked for. IMO that is unnecessary bureaucracy and discourages review from people that are not core developers. Sure the quality of the review may be lower than from core developer but still there's some value in it. So I'd really leave it at the discretion of the maintainer whether he accepts or just ignores Reviewed-by tag. Honza -- Jan Kara SUSE Labs, CR