From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Mark Brown <broonie@kernel.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Jakub Kicinski <kuba@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
Luis Chamberlain <mcgrof@kernel.org>,
Josef Bacik <josef@toxicpanda.com>,
ksummit@lists.linux.dev, Jeff Layton <jlayton@kernel.org>,
Song Liu <song@kernel.org>
Subject: Re: [MAINTAINERS SUMMIT] Maintainer burnout
Date: Mon, 21 Aug 2023 19:04:08 +0300 [thread overview]
Message-ID: <20230821160408.GK10135@pendragon.ideasonboard.com> (raw)
In-Reply-To: <e1b0f9e6-8e40-4365-868b-8340153e6a9c@sirena.org.uk>
On Fri, Aug 18, 2023 at 05:10:07PM +0100, Mark Brown wrote:
> On Fri, Aug 18, 2023 at 06:26:29PM +0300, Laurent Pinchart wrote:
> > On Fri, Aug 18, 2023 at 03:55:11PM +0200, Linus Walleij wrote:
>
> > > The DRI/DRM community has group maintainership that works a little
> > > bit.
> > > Essentially it boils down to ask people to review your stuff and you
> > > will review and also merge their stuff in return.
> > > Sometimes this works.
> > > Especially if you are a circle of acquaintances working full
> > > time on similar things, yay! So much support.
> > > When you are a sporadic contributor it doesn't work as well.
> > > Because you cannot always find some matching contribution to
> > > review and you feel like begging.
> > > So different solutions for different contributors may be needed.
>
> > I've also experienced mixed results from "trading reviews". It's
> > certainly nice on paper, and it works sometimes, especially when asking
> > contributors to review patches that are directly related to their
> > business interest. I remember asking a contributor from a large company
> > to help me with reviews, to free some of my time to review their
> > patches. The contributor helped with reviewing third-party contributions
> > to the driver they're actively working on. When I asked for help
> > reviewing an entirely separate driver that their employer had no
> > business interest in, however, I faced the "we're busy and don't have
> > time" argument.
> >
> > Maybe part of the solution here, to share the maintenance burden, is to
> > expect contributors, especially the ones with large financial resources,
> > to spent a certain percentage of their time reviewing code that is in
> > their area of expertise but not in their area of business interest.
>
> That issue with people having the background knowledge needed to
> adequately review things they don't have specific experience with can be
> a problem here. It's not typically *harmful* other than issues with
> people doing disproportionately pedantic reviews (which can be a
> problem) but you do still need to keep an eye on things it can feel a
> bit make work so there's a balance with making it an explicit
> requirement.
Most of my reviews point of issues with usage of in-kernel and userspace
APIs, rather than problems specific to the hardware at hand. Developers
who contribute drivers with similar usage patterns of APIs should be
able to help there.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2023-08-21 16:04 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-16 18:08 [MAINTAINERS SUMMIT] Maintainer burnout Josef Bacik
2023-08-16 20:14 ` Luis Chamberlain
2023-08-17 9:39 ` Laurent Pinchart
2023-08-17 12:36 ` Andrew Lunn
2023-08-17 15:19 ` Jakub Kicinski
2023-08-17 23:54 ` Alexei Starovoitov
2023-08-18 13:55 ` Linus Walleij
2023-08-18 15:09 ` Jakub Kicinski
2023-08-18 17:07 ` Linus Torvalds
2023-08-19 6:45 ` Leon Romanovsky
2023-08-21 15:35 ` Laurent Pinchart
2023-08-22 7:41 ` Jiri Kosina
2023-08-22 9:05 ` Hannes Reinecke
2023-08-22 10:13 ` Leon Romanovsky
2023-08-22 11:25 ` Laurent Pinchart
2023-08-21 19:23 ` Vegard Nossum
2023-08-22 4:07 ` Dave Airlie
2023-08-22 9:46 ` Jan Kara
2023-08-22 10:10 ` Christian Brauner
2023-08-22 10:20 ` Jan Kara
2023-08-22 11:29 ` Laurent Pinchart
2023-08-22 11:05 ` Leon Romanovsky
2023-08-22 11:32 ` Laurent Pinchart
2023-08-22 13:47 ` Leon Romanovsky
2023-08-22 13:30 ` Jan Kara
2023-08-29 12:54 ` Steven Rostedt
2023-09-13 9:02 ` Dan Carpenter
2023-08-21 8:50 ` Daniel Vetter
2023-08-21 15:18 ` Jakub Kicinski
2023-08-22 4:12 ` Dave Airlie
2023-08-18 15:26 ` Laurent Pinchart
2023-08-18 15:40 ` Konrad Rzeszutek Wilk
2023-08-18 18:36 ` Mark Brown
2023-08-21 16:13 ` Laurent Pinchart
2023-08-18 16:10 ` Mark Brown
2023-08-21 16:04 ` Laurent Pinchart [this message]
2023-08-24 21:30 ` Jonathan Cameron
2023-08-25 7:05 ` Krzysztof Kozlowski
2023-08-17 12:00 ` Jani Nikula
2023-08-17 12:17 ` Mark Brown
2023-08-17 12:42 ` Laurent Pinchart
2023-08-17 13:56 ` Miguel Ojeda
2023-08-17 15:03 ` Laurent Pinchart
2023-08-17 17:41 ` Miguel Ojeda
2023-08-18 15:30 ` Laurent Pinchart
2023-08-18 16:23 ` Mark Brown
2023-08-18 17:17 ` Laurent Pinchart
2023-08-18 18:00 ` Mark Brown
2023-08-17 14:46 ` Mark Brown
2023-08-17 14:22 ` Steven Rostedt
2023-08-17 15:31 ` Jani Nikula
2023-08-17 14:46 ` Steven Rostedt
2023-08-17 15:33 ` Josef Bacik
2023-08-17 17:10 ` Rodrigo Vivi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230821160408.GK10135@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=alexei.starovoitov@gmail.com \
--cc=andrew@lunn.ch \
--cc=broonie@kernel.org \
--cc=jlayton@kernel.org \
--cc=josef@toxicpanda.com \
--cc=ksummit@lists.linux.dev \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=mcgrof@kernel.org \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).