From: Laura Abbott <labbott@redhat.com>
To: Sasha Levin <Alexander.Levin@microsoft.com>
Cc: ksummit <ksummit-discuss@lists.linuxfoundation.org>
Subject: Re: [Ksummit-discuss] [MAINTAINERS SUMMIT] Bug-introducing patches
Date: Fri, 7 Sep 2018 08:54:54 -0700 [thread overview]
Message-ID: <9fb15d7c-c59f-ee21-9c30-6d81d53a1456@redhat.com> (raw)
In-Reply-To: <20180907150623.GH16300@sasha-vm>
On 09/07/2018 08:06 AM, Sasha Levin wrote:
> On Fri, Sep 07, 2018 at 07:37:06AM -0700, Laura Abbott wrote:
>> On 09/06/2018 07:52 PM, Guenter Roeck wrote:
>>> On 09/06/2018 06:49 PM, Sasha Levin via Ksummit-discuss wrote:
>>>>
>>>> This is a *huge* reason why we see regressions in Stable. Take a look at
>>>> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.linuxfoundation.org%2Fpipermail%2Fksummit-discuss%2F2018-September%2F005287.html&data=02%7C01%7CAlexander.Levin%40microsoft.com%7Cf206ee69bd71452d0d8d08d614cf64a5%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636719278316194423&sdata=rYS7lCcdGMzo0kbFowVot790z8GV2Alr1ynEBd1X6qA%3D&reserved=0
>>>> for a list of recent user visible regressions the CoreOS folks have
>>>> observed this year. Do you want to know when they were merged? Let me
>>>> help you: all but one were merged in -rc5 or later.
>>>>
>>>
>>> My conclusion from that would be that patches are applied to stable
>>> before they had time to soak in mainline. Your argument against
>>> accepting patches into mainline might as well be applied to patches
>>> applied to stable.
>>>
>>> I think you are a bit hypocritical arguing that patches should be
>>> restricted from being accepted into mainline ... when at the same
>>> time patches are at least sometimes applied almost immediately to
>>> stable releases from there. Plus, some if not many of the patches
>>> applied to stable releases nowadays don't really fix critical or
>>> even severe bugs. If the patches mentioned above indeed caused
>>> regressions in mainline, those regressions should have been found
>>> and fixed _before_ the patches made it into stable releases.
>>> Blaming mainline for the problem is just shifting the blame.
>>>
>>> I would argue that, if anything, the rules for accepting patches into
>>> _stable_ releases should be much more strict than they are today.
>>> If anything, we need to look into that, not into restricting patch
>>> access to mainline.
>>
>> Part of my proposal for a longer -rc time for stable was for this
>> exact problem: patches that have been merged in mainline but
>> tagged for stable may not have had time to test to find all
>> bugs. The thought was a longer stable -rc cycle would help
>> in finding those. I think you've hit upon the real problem
>> though which is that the patches probably shouldn't have been
>> in stable in the first place.
>
> Let me use the CoreOS example here again. Here are the 5 user visible
> stable regressions they had this year:
>
> 8844618d8aa ("ext4: only look at the bg_flags field if it is valid")
> f46ecbd97f5 ("cifs: Fix slab-out-of-bounds in send_set_info() on SMB2
> ACE setting")
> a6f81fcb2c3 ("tcp: avoid integer overflows in tcp_rcv_space_adjust()")
> 7b2ee50c0cd ("hv_netvsc: common detach logic")
> f599c64fdf7 ("xen-netfront: Fix race between device setup and open")
> a93bf0ff449 ("vxlan: update skb dst pmtu on tx path")
>
> Which of those patches would you not take in a stable tree in the first
> place?
Okay let me see if I can choose my wording better so I'm not going
around in circles.
I don't disagree that those patches look like they should go in stable.
My issue is that a stable release went out with those patches in them
when they were buggy. We're very good at finding patches for stable
which fix bugs. We're less good at finding buggy patches themselves
in stable. Can we make more of a distinction between patches that
are proposed for stable (all of those patches) and patches that
have had enough testing to be included in stable (probably not those
patches)? I'd like to answer the question of what more could be done
(testing?) to identify those patches which are tagged as fixing
bugs but are also still buggy.
Thanks,
Laura
next prev parent reply other threads:[~2018-09-07 15:54 UTC|newest]
Thread overview: 138+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-04 20:16 [Ksummit-discuss] [MAINTAINERS SUMMIT] Bug-introducing patches Sasha Levin
2018-09-04 20:53 ` Daniel Vetter
2018-09-05 14:17 ` Steven Rostedt
2018-09-07 0:51 ` Sasha Levin
2018-09-07 1:09 ` Steven Rostedt
2018-09-07 20:12 ` Greg KH
2018-09-07 21:12 ` Greg KH
2018-09-07 1:09 ` Linus Torvalds
2018-09-07 1:49 ` Sasha Levin
2018-09-07 2:31 ` Linus Torvalds
2018-09-07 2:45 ` Steven Rostedt
2018-09-07 3:43 ` Linus Torvalds
2018-09-07 8:52 ` Daniel Vetter
2018-09-07 8:40 ` Geert Uytterhoeven
2018-09-07 9:07 ` Daniel Vetter
2018-09-07 9:28 ` Geert Uytterhoeven
2018-09-07 17:05 ` Olof Johansson
2018-09-07 14:54 ` Sasha Levin
2018-09-07 15:52 ` Linus Torvalds
2018-09-07 16:17 ` Linus Torvalds
2018-09-07 21:39 ` Mauro Carvalho Chehab
2018-09-09 12:50 ` Stephen Rothwell
2018-09-10 20:05 ` Tony Lindgren
2018-09-10 19:43 ` Sasha Levin
2018-09-10 20:45 ` Steven Rostedt
2018-09-10 21:20 ` Guenter Roeck
2018-09-10 21:46 ` Steven Rostedt
2018-09-10 23:03 ` Eduardo Valentin
2018-09-10 23:13 ` Steven Rostedt
2018-09-11 15:42 ` Steven Rostedt
2018-09-11 17:40 ` Tony Lindgren
2018-09-11 17:47 ` James Bottomley
2018-09-11 18:12 ` Eduardo Valentin
2018-09-11 18:17 ` Geert Uytterhoeven
2018-09-12 15:15 ` Eduardo Valentin
2018-09-11 18:19 ` James Bottomley
2018-09-12 15:17 ` Eduardo Valentin
2018-09-11 18:39 ` Steven Rostedt
2018-09-11 20:09 ` James Bottomley
2018-09-11 20:31 ` Steven Rostedt
2018-09-11 22:53 ` James Bottomley
2018-09-11 23:04 ` Sasha Levin
2018-09-11 23:11 ` James Bottomley
2018-09-11 23:20 ` Sasha Levin
2018-09-12 15:41 ` Eduardo Valentin
2018-09-11 23:22 ` Tony Lindgren
2018-09-11 23:29 ` James Bottomley
2018-09-12 11:55 ` Geert Uytterhoeven
2018-09-12 12:03 ` Laurent Pinchart
2018-09-12 12:29 ` Thomas Gleixner
2018-09-12 12:53 ` Laurent Pinchart
2018-09-12 13:10 ` Alexandre Belloni
2018-09-12 13:30 ` Thomas Gleixner
2018-09-12 23:16 ` Laurent Pinchart
2018-09-12 14:11 ` Thomas Gleixner
2018-09-19 8:26 ` Laurent Pinchart
2018-09-20 9:02 ` Rafael J. Wysocki
2018-09-20 10:10 ` Laurent Pinchart
2018-09-20 11:00 ` Daniel Vetter
2018-09-20 11:08 ` Laurent Pinchart
2018-09-20 11:49 ` Daniel Vetter
2018-09-12 12:36 ` James Bottomley
2018-09-12 13:38 ` Guenter Roeck
2018-09-12 13:59 ` Tony Lindgren
2018-09-12 10:04 ` Mark Brown
2018-09-12 20:24 ` Steven Rostedt
2018-09-12 20:29 ` Sasha Levin
2018-09-13 0:19 ` Stephen Rothwell
2018-09-13 11:39 ` Mark Brown
2018-09-19 6:27 ` Stephen Rothwell
2018-09-19 17:24 ` Mark Brown
2018-09-19 21:42 ` Stephen Rothwell
2018-09-11 0:49 ` Stephen Rothwell
2018-09-11 1:01 ` Al Viro
2018-09-11 0:47 ` Stephen Rothwell
2018-09-11 17:35 ` Linus Torvalds
2018-09-11 0:43 ` Stephen Rothwell
2018-09-11 16:49 ` Guenter Roeck
2018-09-11 17:47 ` Guenter Roeck
2018-09-11 11:18 ` Mark Brown
2018-09-11 17:02 ` Guenter Roeck
2018-09-11 17:12 ` Jani Nikula
2018-09-11 17:31 ` Mark Brown
2018-09-11 17:41 ` Daniel Vetter
2018-09-11 18:54 ` Mark Brown
2018-09-11 18:03 ` Geert Uytterhoeven
2018-09-11 17:22 ` James Bottomley
2018-09-11 17:56 ` Mark Brown
2018-09-11 18:00 ` James Bottomley
2018-09-11 18:16 ` Mark Brown
2018-09-11 18:07 ` Geert Uytterhoeven
2018-09-12 9:09 ` Dan Carpenter
2018-09-11 17:26 ` Mark Brown
2018-09-11 18:45 ` Steven Rostedt
2018-09-11 18:57 ` Daniel Vetter
2018-09-11 20:15 ` Thomas Gleixner
2018-09-12 9:03 ` Dan Carpenter
2018-09-10 23:01 ` Eduardo Valentin
2018-09-10 23:12 ` Steven Rostedt
2018-09-10 23:32 ` Eduardo Valentin
2018-09-10 23:38 ` Guenter Roeck
2018-09-10 23:38 ` Sasha Levin
2018-09-07 2:33 ` Steven Rostedt
2018-09-07 2:52 ` Guenter Roeck
2018-09-07 14:37 ` Laura Abbott
2018-09-07 15:06 ` Sasha Levin
2018-09-07 15:54 ` Laura Abbott [this message]
2018-09-07 16:09 ` Sasha Levin
2018-09-07 20:23 ` Greg KH
2018-09-07 21:13 ` Sasha Levin
2018-09-07 22:27 ` Linus Torvalds
2018-09-07 22:43 ` Guenter Roeck
2018-09-07 22:53 ` Linus Torvalds
2018-09-07 22:57 ` Sasha Levin
2018-09-07 23:52 ` Guenter Roeck
2018-09-08 16:33 ` Greg Kroah-Hartman
2018-09-08 18:35 ` Guenter Roeck
2018-09-10 13:47 ` Mark Brown
2018-09-09 4:36 ` Sasha Levin
2018-09-10 16:20 ` Dan Rue
2018-09-07 21:32 ` Dan Carpenter
2018-09-07 21:43 ` Sasha Levin
2018-09-08 13:20 ` Dan Carpenter
2018-09-10 8:23 ` Jan Kara
2018-09-10 7:53 ` Jan Kara
2018-09-07 3:38 ` Al Viro
2018-09-07 4:27 ` Theodore Y. Ts'o
2018-09-07 5:45 ` Stephen Rothwell
2018-09-07 9:13 ` Daniel Vetter
2018-09-07 11:32 ` Mark Brown
2018-09-07 21:06 ` Mauro Carvalho Chehab
2018-09-08 9:44 ` Laurent Pinchart
2018-09-08 11:48 ` Mauro Carvalho Chehab
2018-09-09 14:26 ` Laurent Pinchart
2018-09-10 22:14 ` Eduardo Valentin
2018-09-07 14:56 ` Sasha Levin
2018-09-07 15:07 ` Jens Axboe
2018-09-07 20:58 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9fb15d7c-c59f-ee21-9c30-6d81d53a1456@redhat.com \
--to=labbott@redhat.com \
--cc=Alexander.Levin@microsoft.com \
--cc=ksummit-discuss@lists.linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).