From: Thomas Gleixner <tglx@linutronix.de>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: ksummit-discuss@lists.linuxfoundation.org
Subject: Re: [Ksummit-discuss] [MAINTAINERS SUMMIT] Patch version changes in commit logs?
Date: Tue, 2 Jul 2019 17:30:06 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.1907021719320.1802@nanos.tec.linutronix.de> (raw)
In-Reply-To: <1562080257.3321.19.camel@HansenPartnership.com>
On Tue, 2 Jul 2019, James Bottomley wrote:
> On Tue, 2019-07-02 at 16:49 +0200, Thomas Gleixner wrote:
> > On Tue, 2 Jul 2019, James Bottomley wrote:
> > > On Mon, 2019-07-01 at 19:54 +0200, Thomas Gleixner wrote:
> > > > The link to V2 is in both cases in the cover letter. That's
> > > > sufficient. Yes, it might not be necessary, but I just recently
> > > > ended up wasting an hour finding an earlier version because the
> > > > cover letter subject changed slightly. I surely have better
> > > > things to do.
> > >
> > > I'm not arguing against changelogs in the patches themselves as
> > > long as they're below the commit message --- cutoff. In fact I
> > > think that's best practice for reviewers. I'm just arguing making
> > > a link tag mandatory would impose an enforcement burden on a lot of
> > > subsystems which would provide no benefit to them), so I don't mind
> > > it's being optional but it shouldn't be mandatory.
> >
> > What's the burden exactly?
>
> Not everyone knows what a message ID is or how to find it, so we'd have
> to explain why the patch was rejected (or simply have the maintainer
> add it at commit time, which currently involves some effort). Quite a
> few of the list archives mangle it so someone would have to notice this
> or unmangle it.
>
> > You mean that people would have to add them manually?
>
> Most email tools don't show you the msgid, so if you're simply doing
> driveby commits now we have to explain to you how to find it ...
> remember linux-scsi isn't currently on lore so we can't just say "use
> the lore archive".
The submitter has not to do anything for a drive by patch. The maintainer
who grabs it from the list adds the tags (with tools).
> There's also a knock on: for this to be useful, the commit series needs
> to be threaded. I've actually no objection to making this one
> mandatory I'm just noting it's another precursor we need to think
> about.
>
> > People who use the link tag today have their homebrewn scripts to add
> > them automatically and it shouldn't be rocket science to add that to
> > git, patchwork whatever.
>
> So if we find a way of automating this globally, I'm completely happy.
> However, I would also note that whatever script does this could likely
> also be run by you after the fact to generate the back link, so
> foolproof automation also lessens the need to make this a mandatory
> commit tag.
That's what I'm doing today. My mbox to quilt converter inserts the Link
tag.
So let's take a step back.
1) Link tag in the commit itself.
That's added by the person who applies a patch from mail,
i.e. maintainer.
That needs tooling support in git, patchwork etc. which should be a
solvable problem.
2) Link to a previous version of patch series in the cover letter
Lot of people provide already links in their cover letter. Many of them
unfortunately use lkml.org which is a pain, but it's better than
nothing.
Ideally we can bring people to use the MSG id based links because they
do not depend on any particular archive.
That needs a bit more education. Proper documentation should solve that
over time. If people use lkml.org for the link until they figure out
what a message id is, fine.
Thanks,
tglx
next prev parent reply other threads:[~2019-07-02 15:30 UTC|newest]
Thread overview: 106+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 20:11 [Ksummit-discuss] [MAINTAINERS SUMMIT] Patch version changes in commit logs? Shuah Khan
2019-06-28 20:51 ` Luck, Tony
2019-06-28 21:05 ` Kees Cook
2019-06-28 21:07 ` Shuah Khan
2019-06-28 21:13 ` James Bottomley
2019-06-28 21:42 ` Shuah Khan
2019-06-28 21:07 ` Wolfram Sang
2019-06-29 6:19 ` Thomas Gleixner
2019-06-29 9:10 ` Christian Brauner
2019-06-29 13:43 ` Andrea Parri
2019-06-29 15:16 ` Thomas Gleixner
2019-06-30 16:31 ` Konstantin Ryabitsev
2019-07-01 7:20 ` Peter Zijlstra
2019-07-01 7:49 ` Thomas Gleixner
2019-07-01 7:53 ` Takashi Iwai
2019-07-17 9:23 ` Dan Carpenter
2019-07-17 9:27 ` Dan Carpenter
2019-07-17 9:28 ` Greg KH
2019-07-17 16:09 ` Linus Walleij
2019-07-17 20:44 ` Greg KH
2019-07-18 9:09 ` Linus Walleij
2019-07-22 17:02 ` Kees Cook
2019-07-22 17:12 ` Joe Perches
2019-07-01 17:27 ` Steven Rostedt
2019-07-01 17:55 ` Thomas Gleixner
2019-07-01 9:48 ` Andrea Parri
2019-07-01 9:51 ` Andrea Parri
2019-07-02 4:40 ` Leon Romanovsky
2019-07-02 7:27 ` Geert Uytterhoeven
2019-07-02 9:48 ` Leon Romanovsky
2019-06-29 6:57 ` Takashi Iwai
2019-06-29 7:09 ` Thomas Gleixner
2019-06-29 7:18 ` Takashi Iwai
2019-06-29 11:20 ` Mark Brown
2019-06-30 16:01 ` Mauro Carvalho Chehab
2019-07-01 1:35 ` Andrew Donnellan
2019-07-01 11:10 ` Mark Brown
2019-08-08 5:24 ` Andrew Donnellan
2019-07-01 9:05 ` Jiri Kosina
2019-07-01 9:15 ` Sergey Senozhatsky
2019-07-04 12:15 ` Michael Ellerman
2019-07-04 13:24 ` Geert Uytterhoeven
2019-07-04 14:16 ` Thomas Gleixner
2019-07-05 3:37 ` Michael Ellerman
2019-07-05 4:10 ` Michael Ellerman
2019-07-05 6:28 ` Thomas Gleixner
2019-07-05 8:24 ` Geert Uytterhoeven
2019-07-04 14:22 ` James Bottomley
2019-07-05 3:24 ` Michael Ellerman
2019-07-06 14:02 ` Alexandre Belloni
2019-07-06 14:57 ` James Bottomley
2019-07-05 3:40 ` Michael Ellerman
2019-07-05 8:40 ` Geert Uytterhoeven
2019-06-28 21:07 ` James Bottomley
2019-07-01 15:06 ` David Howells
2019-07-01 15:40 ` Thomas Gleixner
2019-07-01 15:48 ` Laurent Pinchart
2019-07-01 15:50 ` James Bottomley
2019-07-01 17:54 ` Thomas Gleixner
2019-07-02 14:20 ` James Bottomley
2019-07-02 14:49 ` Thomas Gleixner
2019-07-02 15:10 ` James Bottomley
2019-07-02 15:18 ` James Bottomley
2019-07-02 15:39 ` Shuah Khan
2019-07-02 15:51 ` James Bottomley
2019-07-02 16:30 ` Kees Cook
2019-07-02 21:16 ` Konstantin Ryabitsev
2019-07-02 21:33 ` James Bottomley
2019-07-02 22:07 ` Thomas Gleixner
2019-07-02 22:26 ` James Bottomley
2019-07-02 22:43 ` Theodore Ts'o
2019-07-02 22:49 ` Thomas Gleixner
2019-07-03 23:52 ` Ralf Ramsauer
2019-07-02 22:53 ` James Bottomley
2019-07-02 23:12 ` Thomas Gleixner
2019-07-02 23:04 ` Kees Cook
2019-07-02 23:18 ` Theodore Ts'o
2019-07-02 23:31 ` Kees Cook
2019-07-02 23:33 ` James Bottomley
2019-07-03 4:16 ` Theodore Ts'o
2019-07-03 4:50 ` James Bottomley
2019-07-03 14:42 ` Kees Cook
2019-07-02 23:41 ` Kees Cook
2019-07-03 7:51 ` Greg KH
2019-07-03 8:56 ` Laurent Pinchart
2019-07-03 9:12 ` Thomas Gleixner
2019-07-03 12:39 ` Leon Romanovsky
2019-07-03 22:53 ` Laurent Pinchart
2019-07-03 13:50 ` Theodore Ts'o
2019-07-03 14:10 ` Jan Kara
2019-07-03 17:05 ` Mark Brown
2019-07-03 19:11 ` Frank Rowand
2019-07-05 9:26 ` Linus Walleij
2019-07-05 19:34 ` Mike Rapoport
2019-07-06 4:42 ` Theodore Ts'o
2019-07-07 21:56 ` Frank Rowand
2019-07-03 23:03 ` James Bottomley
2019-07-04 7:10 ` Geert Uytterhoeven
2019-07-05 9:03 ` Linus Walleij
2019-07-02 22:48 ` Thomas Gleixner
2019-07-02 23:05 ` James Bottomley
2019-07-02 19:03 ` Shuah Khan
2019-07-02 15:30 ` Thomas Gleixner [this message]
2019-07-02 15:40 ` James Bottomley
2019-07-02 15:49 ` Thomas Gleixner
2019-07-02 20:44 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1907021719320.1802@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=ksummit-discuss@lists.linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).