From: Paolo Bonzini <pbonzini@redhat.com>
To: kvm-ia64@vger.kernel.org
Subject: Re: [PATCH v13 6/7] arm: KVM: dirty log read write protect support
Date: Sat, 08 Nov 2014 07:28:50 +0000 [thread overview]
Message-ID: <545DC632.6020002@redhat.com> (raw)
In-Reply-To: <1415320848-13813-7-git-send-email-m.smarduch@samsung.com>
On 07/11/2014 20:47, Mario Smarduch wrote:
>> That can happen if the error occurred in the final
>> copy to userspace, after page tables have been modified.
>
> Upon error return userspace should terminate logging, error out whether
> used for migration or other use cases, with some stale spte TLBs cached
> read/write, which doesn't appear to be harmful.
Fair enough; for x86 I elected to always do the TLB flush, but you can
do it differently. Perhaps add a comment with the above paragraph, thouhg.
> But you mention 'final copy' which makes me think I'm missing something?
I meant final copy before leaving the function.
Paolo
prev parent reply other threads:[~2014-11-08 7:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-07 0:40 [PATCH v13 6/7] arm: KVM: dirty log read write protect support Mario Smarduch
2014-11-07 7:38 ` Paolo Bonzini
2014-11-07 10:19 ` Marc Zyngier
2014-11-07 19:47 ` Mario Smarduch
2014-11-08 7:28 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545DC632.6020002@redhat.com \
--to=pbonzini@redhat.com \
--cc=kvm-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).