From: Thomas Huth <thuth@redhat.com>
To: kvm@vger.kernel.org, Laurent Vivier <lvivier@redhat.com>,
Andrew Jones <drjones@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm-ppc@vger.kernel.org, Eric Auger <eric.auger@redhat.com>
Subject: [kvm-unit-tests PATCH] scripts/arch-run: Mark migration tests as SKIP if ncat is not available
Date: Tue, 21 Dec 2021 09:21:30 +0000 [thread overview]
Message-ID: <20211221092130.444225-1-thuth@redhat.com> (raw)
Instead of failing the tests, we should rather skip them if ncat is
not available.
While we're at it, also mention ncat in the README.md file as a
requirement for the migration tests.
Resolves: https://gitlab.com/kvm-unit-tests/kvm-unit-tests/-/issues/4
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
README.md | 4 ++++
scripts/arch-run.bash | 2 +-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/README.md b/README.md
index 6e6a9d0..a82da56 100644
--- a/README.md
+++ b/README.md
@@ -54,6 +54,10 @@ ACCEL=name environment variable:
ACCEL=kvm ./x86-run ./x86/msr.flat
+For running tests that involve migration from one QEMU instance to another
+you also need to have the "ncat" binary (from the nmap.org project) installed,
+otherwise the related tests will be skipped.
+
# Tests configuration file
The test case may need specific runtime configurations, for
diff --git a/scripts/arch-run.bash b/scripts/arch-run.bash
index 43da998..cd92ed9 100644
--- a/scripts/arch-run.bash
+++ b/scripts/arch-run.bash
@@ -108,7 +108,7 @@ run_migration ()
{
if ! command -v ncat >/dev/null 2>&1; then
echo "${FUNCNAME[0]} needs ncat (netcat)" >&2
- return 2
+ return 77
fi
migsock=$(mktemp -u -t mig-helper-socket.XXXXXXXXXX)
--
2.27.0
next reply other threads:[~2021-12-21 9:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-21 9:21 Thomas Huth [this message]
2021-12-21 9:58 ` [kvm-unit-tests PATCH] scripts/arch-run: Mark migration tests as SKIP if ncat is not available Paolo Bonzini
2021-12-21 10:12 ` Thomas Huth
2021-12-21 14:48 ` Eric Auger
2021-12-21 17:25 ` Paolo Bonzini
2021-12-23 15:46 ` Andrew Jones
2021-12-27 19:29 ` Thomas Huth
2021-12-23 15:50 ` Andrew Jones
2022-01-18 14:24 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211221092130.444225-1-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=drjones@redhat.com \
--cc=eric.auger@redhat.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).