From: Fabiano Rosas <farosas@linux.ibm.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>, linuxppc-dev@lists.ozlabs.org
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>,
kvm-ppc@vger.kernel.org, Nicholas Piggin <npiggin@gmail.com>,
Frederic Barrat <fbarrat@linux.ibm.com>
Subject: Re: [PATCH kernel] KVM: PPC: Book3s: Retire H_PUT_TCE/etc real mode handlers
Date: Mon, 02 May 2022 17:53:06 +0000 [thread overview]
Message-ID: <87v8unx1ml.fsf@linux.ibm.com> (raw)
In-Reply-To: <20220428071627.1767104-1-aik@ozlabs.ru>
Alexey Kardashevskiy <aik@ozlabs.ru> writes:
> diff --git a/arch/powerpc/kvm/book3s_hv_rmhandlers.S b/arch/powerpc/kvm/book3s_hv_rmhandlers.S
> index d185dee26026..44d74bfe05df 100644
> --- a/arch/powerpc/kvm/book3s_hv_rmhandlers.S
> +++ b/arch/powerpc/kvm/book3s_hv_rmhandlers.S
> @@ -1784,13 +1784,8 @@ hcall_real_table:
> .long DOTSYM(kvmppc_h_clear_mod) - hcall_real_table
> .long DOTSYM(kvmppc_h_clear_ref) - hcall_real_table
> .long DOTSYM(kvmppc_h_protect) - hcall_real_table
> -#ifdef CONFIG_SPAPR_TCE_IOMMU
> - .long DOTSYM(kvmppc_h_get_tce) - hcall_real_table
> - .long DOTSYM(kvmppc_rm_h_put_tce) - hcall_real_table
> -#else
> .long 0 /* 0x1c */
> .long 0 /* 0x20 */
> -#endif
> .long 0 /* 0x24 - H_SET_SPRG0 */
> .long DOTSYM(kvmppc_h_set_dabr) - hcall_real_table
> .long DOTSYM(kvmppc_rm_h_page_init) - hcall_real_table
> @@ -1868,13 +1863,8 @@ hcall_real_table:
> .long 0 /* 0x12c */
> .long 0 /* 0x130 */
> .long DOTSYM(kvmppc_h_set_xdabr) - hcall_real_table
> -#ifdef CONFIG_SPAPR_TCE_IOMMU
> - .long DOTSYM(kvmppc_rm_h_stuff_tce) - hcall_real_table
> - .long DOTSYM(kvmppc_rm_h_put_tce_indirect) - hcall_real_table
> -#else
> .long 0 /* 0x138 */
> .long 0 /* 0x13c */
> -#endif
> .long 0 /* 0x140 */
> .long 0 /* 0x144 */
> .long 0 /* 0x148 */
The ones you remove from here need to be added to kvmppc_hcall_impl_hv,
otherwise we get the WARN at init_default_hcalls because
kvmppc_hcall_impl_hv_realmode can't find them.
prev parent reply other threads:[~2022-05-02 17:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-28 7:16 [PATCH kernel] KVM: PPC: Book3s: Retire H_PUT_TCE/etc real mode handlers Alexey Kardashevskiy
2022-05-02 17:53 ` Fabiano Rosas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8unx1ml.fsf@linux.ibm.com \
--to=farosas@linux.ibm.com \
--cc=aik@ozlabs.ru \
--cc=fbarrat@linux.ibm.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).