From: Kautuk Consul <kconsul@linux.vnet.ibm.com>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: Thomas Huth <thuth@redhat.com>,
aik@ozlabs.ru, groug@kaod.org, slof@lists.ozlabs.org,
kvm-ppc@vger.kernel.org
Subject: Re: [PATCH v2] slof/engine.in: refine +COMP and -COMP by not using COMPILE
Date: Mon, 18 Mar 2024 10:42:53 +0530 [thread overview]
Message-ID: <ZffNVdhtAzY32Jsx@li-a450e7cc-27df-11b2-a85c-b5a9ac31e8ef.ibm.com> (raw)
In-Reply-To: <ZelfudAMYcXGCgBN@li-a450e7cc-27df-11b2-a85c-b5a9ac31e8ef.ibm.com>
Hi Segher,
>
> > > If you want to improve engine.in, get rid of it completely? Make the
> > > whol thing cross-compile perhaps. Everything from source code. The
> > > engine.in thing is essentially an already compiled thing (but not
> > > relocated yet, not fixed to some address), which is still in mostly
> > > obvious 1-1 correspondence to it source code, which can be easily
> > > "uncompiled" as well. Like:
> >
> > :-). Getting rid of it completely and making the whole thing
> > cross-compile would require more time that I'm not so sure that I or
> > even my manager would be able to spare in our project.
> >
> > >
> > > col(+COMP STATE @ 1 STATE +! 0BRANCH(1) EXIT HERE THERE ! COMP-BUFFER DOTO HERE COMPILE DOCOL)
> > > col(-COMP -1 STATE +! STATE @ 0BRANCH(1) EXIT COMPILE EXIT THERE @ DOTO HERE COMP-BUFFER EXECUTE)
> > >
> > > : +comp ( -- )
> > > state @ 1 state +! IF exit THEN
> > > here there !
> > > comp-buffer to here
> > > compile docol ;
> > > : -comp ( -- )
> > > -1 state +!
> > > state @ IF exit THEN
> > > compile exit
> > > there @ to here
> > > comp-buffer execute ;
> > >
> > > "['] semicolon compile," is not something a user would ever write. A
> > > user would write "compile exit". It is standard Forth, it works
> > > anywhere. It is much more idiomatic..
> >
> > Okay, I can accept the fact that maybe we should use EXIT instead of
> > SEMICOLON. But at least can we remove the invocation of the "COMPILE"
> > keyword in +COMP and -COMP ? The rest of the compiler in slof/engine.in
> > uses the standard "DOTICK <word> COMPILE," format so why cannot we use
> > this for -COMP as well as +COMP ?
> >
Do you all agree with the above reasoning as well as the fact that I think
we would all here (in the KVM team) appreciate even this small
improvement in performance ?
Can I send a v3 patch with the "DOTICK EXIT COMPILE," "DOTICK DOCOL COMPILE," changes ?
next prev parent reply other threads:[~2024-03-18 5:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-02 5:15 [PATCH v2] slof/engine.in: refine +COMP and -COMP by not using COMPILE Kautuk Consul
2024-02-12 9:28 ` Kautuk Consul
2024-02-23 20:57 ` Segher Boessenkool
2024-02-26 4:39 ` Kautuk Consul
2024-03-07 6:33 ` Kautuk Consul
2024-03-18 5:12 ` Kautuk Consul [this message]
2024-05-22 9:04 ` Kautuk Consul
2024-05-27 12:33 ` Alexey Kardashevskiy
2024-05-28 4:02 ` Kautuk Consul
2024-02-22 7:38 ` Kautuk Consul
2024-02-22 9:04 ` Thomas Huth
2024-02-22 11:46 ` Kautuk Consul
2024-02-23 5:59 ` Kautuk Consul
2024-02-23 21:04 ` Segher Boessenkool
2024-02-26 4:32 ` Kautuk Consul
2024-02-26 4:43 ` Kautuk Consul
2024-02-26 6:47 ` Kautuk Consul
2024-02-26 6:59 ` Kautuk Consul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZffNVdhtAzY32Jsx@li-a450e7cc-27df-11b2-a85c-b5a9ac31e8ef.ibm.com \
--to=kconsul@linux.vnet.ibm.com \
--cc=aik@ozlabs.ru \
--cc=groug@kaod.org \
--cc=kvm-ppc@vger.kernel.org \
--cc=segher@kernel.crashing.org \
--cc=slof@lists.ozlabs.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).