From: Kautuk Consul <kconsul@linux.ibm.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: Thomas Huth <thuth@redhat.com>,
slof@lists.ozlabs.org, kvm-ppc@vger.kernel.org
Subject: Re: [SLOF] [PATCH v4] slof/fs/packages/disk-label.fs: improve checking for DOS boot partitions
Date: Fri, 3 May 2024 15:38:41 +0530 [thread overview]
Message-ID: <ZjS3qfuj+iopSZjR@li-a450e7cc-27df-11b2-a85c-b5a9ac31e8ef.ibm.com> (raw)
In-Reply-To: <Zh3/nZVuncUmcXq0@li-a450e7cc-27df-11b2-a85c-b5a9ac31e8ef.ibm.com>
Hi Alexey/Segher,
> > :-). But this is the only other path that doesn't have a CATCH
> > like the do-load subroutine in slof/fs/boot.fs. According to Segher
> > there shouldn't ever be a problem with throw because if nothing else the
> > outer-most interpreter loop's CATCH will catch the exception. But I
> > thought to cover this throw in read-sector more locally in places near
> > to this functionality. Because the outermost FORTH SLOF interpreter loop is not
> > really so related to reading a sector in disk-label.fs.
> >
> Alexey/Segher, so what should be the next steps ?
> Do you find my explanation above okay or should I simply remove these
> CATCH blocks ? Putting a CATCH block in count-dos-logical-partitions is
> out of the question as there is already a CATCH in do-load in
> slof/fs/boot.fs. This CATCH block in the open subroutine is actually to
> prevent the exception to be caught at some non-local place in the code.
Any ideas on how we proceed with this now ?
> _______________________________________________
> SLOF mailing list
> SLOF@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/slof
next prev parent reply other threads:[~2024-05-03 10:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-28 6:00 [PATCH v4] slof/fs/packages/disk-label.fs: improve checking for DOS boot partitions Kautuk Consul
2024-04-04 0:35 ` Alexey Kardashevskiy
2024-04-04 7:18 ` Kautuk Consul
2024-04-05 3:46 ` Alexey Kardashevskiy
2024-04-05 8:16 ` Kautuk Consul
2024-04-16 4:33 ` [SLOF] " Kautuk Consul
2024-04-25 7:14 ` Kautuk Consul
2024-05-03 10:08 ` Kautuk Consul [this message]
2024-05-14 9:08 ` Kautuk Consul
2024-05-20 9:03 ` Alexey Kardashevskiy
2024-05-22 8:55 ` Kautuk Consul
2024-05-27 12:38 ` Alexey Kardashevskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZjS3qfuj+iopSZjR@li-a450e7cc-27df-11b2-a85c-b5a9ac31e8ef.ibm.com \
--to=kconsul@linux.ibm.com \
--cc=aik@ozlabs.ru \
--cc=kvm-ppc@vger.kernel.org \
--cc=slof@lists.ozlabs.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).