KVM Archive mirror
 help / color / mirror / Atom feed
From: Tom Lendacky <thomas.lendacky@amd.com>
To: Li RongQing <lirongqing@baidu.com>,
	seanjc@google.com, pbonzini@redhat.com, kvm@vger.kernel.org,
	yosryahmed@google.com, pgonda@google.com
Subject: Re: [PATCH v3 3/3] KVM: SVM: Consider NUMA affinity when allocating per-CPU save_area
Date: Mon, 20 May 2024 13:26:33 -0500	[thread overview]
Message-ID: <1d66de5a-673f-c4bf-4f7f-36340e244539@amd.com> (raw)
In-Reply-To: <20240520120858.13117-4-lirongqing@baidu.com>

On 5/20/24 07:08, Li RongQing wrote:
> save_area of per-CPU svm_data are dominantly accessed from their
> own local CPUs, so allocate them node-local for performance reason
> 
> so rename __snp_safe_alloc_page as snp_safe_alloc_page_node which
> accepts numa node id as input parameter, svm_cpu_init call it with
> node id switched from cpu id
> 
> Signed-off-by: Li RongQing <lirongqing@baidu.com>

Reviewed-by: Tom Lendacky <thomas.lendacky@amd.com>

> ---
>   arch/x86/kvm/svm/sev.c |  6 +++---
>   arch/x86/kvm/svm/svm.c |  2 +-
>   arch/x86/kvm/svm/svm.h | 10 +++++-----
>   3 files changed, 9 insertions(+), 9 deletions(-)
> 

  reply	other threads:[~2024-05-20 18:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-20 12:08 [PATCH v3 0/3] KVM: SVM: refine snp_safe_alloc_page() implementation Li RongQing
2024-05-20 12:08 ` [PATCH v3 1/3] KVM: SVM: remove useless input parameter in snp_safe_alloc_page Li RongQing
2024-05-20 18:14   ` Tom Lendacky
2024-05-20 12:08 ` [PATCH v3 2/3] KVM: SVM: not account memory allocation for per-CPU svm_data Li RongQing
2024-05-20 18:17   ` Tom Lendacky
2024-05-20 12:08 ` [PATCH v3 3/3] KVM: SVM: Consider NUMA affinity when allocating per-CPU save_area Li RongQing
2024-05-20 18:26   ` Tom Lendacky [this message]
2024-06-04 23:29 ` [PATCH v3 0/3] KVM: SVM: refine snp_safe_alloc_page() implementation Sean Christopherson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1d66de5a-673f-c4bf-4f7f-36340e244539@amd.com \
    --to=thomas.lendacky@amd.com \
    --cc=kvm@vger.kernel.org \
    --cc=lirongqing@baidu.com \
    --cc=pbonzini@redhat.com \
    --cc=pgonda@google.com \
    --cc=seanjc@google.com \
    --cc=yosryahmed@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).