From: "Clément Léger" <cleger@rivosinc.com>
To: Conor Dooley <conor@kernel.org>
Cc: Jonathan Corbet <corbet@lwn.net>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Anup Patel <anup@brainfault.org>, Shuah Khan <shuah@kernel.org>,
Atish Patra <atishp@atishpatra.org>,
linux-doc@vger.kernel.org, linux-riscv@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
kvm@vger.kernel.org, kvm-riscv@lists.infradead.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v5 07/16] riscv: add ISA extensions validation callback
Date: Tue, 21 May 2024 09:58:25 +0200 [thread overview]
Message-ID: <6d2eb1ec-010d-4390-a25e-afd2fca0311d@rivosinc.com> (raw)
In-Reply-To: <20240517-scrunch-palace-2f83aa8cc3ce@spud>
On 17/05/2024 18:44, Conor Dooley wrote:
> On Fri, May 17, 2024 at 04:52:47PM +0200, Clément Léger wrote:
>> Since a few extensions (Zicbom/Zicboz) already needs validation and
>> future ones will need it as well (Zc*) add a validate() callback to
>> struct riscv_isa_ext_data. This require to rework the way extensions are
>> parsed and split it in two phases. First phase is isa string or isa
>> extension list parsing and consists in enabling all the extensions in a
>> temporary bitmask (source isa) without any validation. The second step
>> "resolves" the final isa bitmap, handling potential missing dependencies.
>> The mechanism is quite simple and simply validate each extension
>> described in the source bitmap before enabling it in the resolved isa
>> bitmap. validate() callbacks can return either 0 for success,
>> -EPROBEDEFER if extension needs to be validated again at next loop. A
>> previous ISA bitmap is kept to avoid looping multiple times if an
>> extension dependencies are never satisfied until we reach a stable
>> state. In order to avoid any potential infinite looping, allow looping
>> a maximum of the number of extension we handle. Zicboz and Zicbom
>> extensions are modified to use this validation mechanism.
>
> I wish we weren't doin' it at all, but since we have to, I think what
> you've got here is good.
Yup, this is what you got with a fast evolving architecture I guess ;)
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
>
> Do you want me to send some patches for the F/V stuff we discussed
> previously?
Sure go ahead, I did not have anything written yet.
Thanks,
Clément
>
> Cheers,
> Conor.
next prev parent reply other threads:[~2024-05-21 7:58 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-17 14:52 [PATCH v5 00/16] Add support for a few Zc* extensions, Zcmop and Zimop Clément Léger
2024-05-17 14:52 ` [PATCH v5 01/16] dt-bindings: riscv: add Zimop ISA extension description Clément Léger
2024-05-29 22:10 ` Charlie Jenkins
2024-05-17 14:52 ` [PATCH v5 02/16] riscv: add ISA extension parsing for Zimop Clément Léger
2024-05-29 22:08 ` Charlie Jenkins
2024-05-29 22:21 ` Charlie Jenkins
2024-05-30 8:12 ` Clément Léger
2024-05-30 14:37 ` Charlie Jenkins
2024-05-30 14:38 ` Clément Léger
2024-05-17 14:52 ` [PATCH v5 03/16] riscv: hwprobe: export Zimop ISA extension Clément Léger
2024-05-29 22:11 ` Charlie Jenkins
2024-05-17 14:52 ` [PATCH v5 04/16] RISC-V: KVM: Allow Zimop extension for Guest/VM Clément Léger
2024-05-17 15:17 ` Anup Patel
2024-05-29 22:16 ` Charlie Jenkins
2024-05-17 14:52 ` [PATCH v5 05/16] KVM: riscv: selftests: Add Zimop extension to get-reg-list test Clément Léger
2024-05-17 15:18 ` Anup Patel
2024-05-17 14:52 ` [PATCH v5 06/16] dt-bindings: riscv: add Zca, Zcf, Zcd and Zcb ISA extension description Clément Léger
2024-05-29 22:13 ` Charlie Jenkins
2024-05-17 14:52 ` [PATCH v5 07/16] riscv: add ISA extensions validation callback Clément Léger
2024-05-17 16:44 ` Conor Dooley
2024-05-21 7:58 ` Clément Léger [this message]
2024-05-17 14:52 ` [PATCH v5 08/16] riscv: add ISA parsing for Zca, Zcf, Zcd and Zcb Clément Léger
2024-05-21 19:49 ` Conor Dooley
2024-05-22 7:20 ` Clément Léger
2024-05-30 21:13 ` Palmer Dabbelt
2024-06-04 7:18 ` Clément Léger
2024-05-17 14:52 ` [PATCH v5 09/16] riscv: hwprobe: export Zca, Zcf, Zcd and Zcb ISA extensions Clément Léger
2024-05-30 15:25 ` Charlie Jenkins
2024-05-17 14:52 ` [PATCH v5 10/16] RISC-V: KVM: Allow Zca, Zcf, Zcd and Zcb extensions for Guest/VM Clément Léger
2024-05-17 14:52 ` [PATCH v5 11/16] KVM: riscv: selftests: Add some Zc* extensions to get-reg-list test Clément Léger
2024-05-17 14:52 ` [PATCH v5 12/16] dt-bindings: riscv: add Zcmop ISA extension description Clément Léger
2024-05-17 14:52 ` [PATCH v5 13/16] riscv: add ISA extension parsing for Zcmop Clément Léger
2024-05-30 15:48 ` Charlie Jenkins
2024-05-17 14:52 ` [PATCH v5 14/16] riscv: hwprobe: export Zcmop ISA extension Clément Léger
2024-05-17 14:52 ` [PATCH v5 15/16] RISC-V: KVM: Allow Zcmop extension for Guest/VM Clément Léger
2024-05-17 14:52 ` [PATCH v5 16/16] KVM: riscv: selftests: Add Zcmop extension to get-reg-list test Clément Léger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d2eb1ec-010d-4390-a25e-afd2fca0311d@rivosinc.com \
--to=cleger@rivosinc.com \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=atishp@atishpatra.org \
--cc=conor@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kvm-riscv@lists.infradead.org \
--cc=kvm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).