From: Dan Williams <dan.j.williams@intel.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Dan Williams" <dan.j.williams@intel.com>,
"Arnd Bergmann" <arnd@arndb.de>
Cc: Len Brown <lenb@kernel.org>, James Morse <james.morse@arm.com>,
Tony Luck <tony.luck@intel.com>, Borislav Petkov <bp@alien8.de>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Avadhut Naik <Avadhut.Naik@amd.com>,
"Ben Cheatham" <Benjamin.Cheatham@amd.com>,
<linux-acpi@vger.kernel.org>, <kernel@pengutronix.de>
Subject: Re: [PATCH] ACPI: APEI: EINJ: mark remove callback as __exit
Date: Fri, 29 Mar 2024 11:55:49 -0700 [thread overview]
Message-ID: <66070eb518072_4a98a294d5@dwillia2-mobl3.amr.corp.intel.com.notmuch> (raw)
In-Reply-To: <20240329100203.540368-2-u.kleine-koenig@pengutronix.de>
Uwe Kleine-König wrote:
> The einj_driver driver is registered using platform_driver_probe(). In
> this case it cannot get unbound via sysfs and it's ok to put the remove
> callback into an exit section. To prevent the modpost warning about
> einj_driver referencing .exit.text, mark the driver struct with
> __refdata and explain the situation in a comment.
>
> This is an improvement over commit a24118a8a687 ("ACPI: APEI: EINJ: mark
> remove callback as non-__exit") which recently addressed the same issue,
> but picked a less optimal variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Thanks for the explanation Uwe, this makes sense.
Rafael, do you want to pick this one up as well?
Reviewed-by: Dan Williams <dan.j.williams@intel.com>
next prev parent reply other threads:[~2024-03-29 18:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-29 10:02 [PATCH] ACPI: APEI: EINJ: mark remove callback as __exit Uwe Kleine-König
2024-03-29 18:55 ` Dan Williams [this message]
2024-04-08 14:22 ` Rafael J. Wysocki
2024-03-30 7:00 ` Arnd Bergmann
2024-04-01 6:16 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66070eb518072_4a98a294d5@dwillia2-mobl3.amr.corp.intel.com.notmuch \
--to=dan.j.williams@intel.com \
--cc=Avadhut.Naik@amd.com \
--cc=Benjamin.Cheatham@amd.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=kernel@pengutronix.de \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=tony.luck@intel.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).