From: Juergen Gross <jgross@suse.com>
To: "Jiqian Chen" <Jiqian.Chen@amd.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Rafael J . Wysocki" <rafael@kernel.org>,
"Roger Pau Monné" <roger.pau@citrix.com>
Cc: xen-devel@lists.xenproject.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
Huang Rui <Ray.Huang@amd.com>
Subject: Re: [RFC KERNEL PATCH v6 2/3] xen/pvh: Setup gsi for passthrough device
Date: Fri, 10 May 2024 09:48:29 +0200 [thread overview]
Message-ID: <9ebdcc0b-3775-4c5e-9ffb-f45d048281dd@suse.com> (raw)
In-Reply-To: <20240419033616.607889-3-Jiqian.Chen@amd.com>
[-- Attachment #1.1.1: Type: text/plain, Size: 1659 bytes --]
On 19.04.24 05:36, Jiqian Chen wrote:
> In PVH dom0, the gsis don't get registered, but the gsi of
> a passthrough device must be configured for it to be able to be
> mapped into a domU.
>
> When assign a device to passthrough, proactively setup the gsi
> of the device during that process.
>
> Co-developed-by: Huang Rui <ray.huang@amd.com>
> Signed-off-by: Jiqian Chen <Jiqian.Chen@amd.com>
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
This patch is breaking the build.
On Arm I get:
In file included from /home/gross/korg/src/drivers/xen/xen-pciback/pci_stub.c:23:0:
/home/gross/korg/src/include/xen/acpi.h: In function 'xen_acpi_sleep_register':
/home/gross/korg/src/include/xen/acpi.h:67:3: error: 'acpi_suspend_lowlevel'
undeclared (first use in this function); did you mean 'xen_acpi_suspend_lowlevel'?
acpi_suspend_lowlevel = xen_acpi_suspend_lowlevel;
^~~~~~~~~~~~~~~~~~~~~
xen_acpi_suspend_lowlevel
/home/gross/korg/src/include/xen/acpi.h:67:3: note: each undeclared identifier
is reported only once for each function it appears in
make[6]: *** [/home/gross/korg/src/scripts/Makefile.build:244:
drivers/xen/xen-pciback/pci_stub.o] Error 1
make[5]: *** [/home/gross/korg/src/scripts/Makefile.build:485:
drivers/xen/xen-pciback] Error 2
make[4]: *** [/home/gross/korg/src/scripts/Makefile.build:485: drivers/xen] Error 2
Additionally I'm seeing this warning on x86_64:
/home/gross/korg/src/arch/x86/xen/enlighten_pvh.c:97:5: warning: no previous
prototype for ‘xen_pvh_passthrough_gsi’ [-Wmissing-prototypes]
int xen_pvh_passthrough_gsi(struct pci_dev *dev)
Juergen
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3743 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
next prev parent reply other threads:[~2024-05-10 7:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-19 3:36 [RFC KERNEL PATCH v6 0/3] Support device passthrough when dom0 is PVH on Xen Jiqian Chen
2024-04-19 3:36 ` [KERNEL PATCH v6 1/3] xen/pci: Add xen_reset_device_state function Jiqian Chen
2024-04-19 3:36 ` [RFC KERNEL PATCH v6 2/3] xen/pvh: Setup gsi for passthrough device Jiqian Chen
2024-05-10 7:48 ` Juergen Gross [this message]
2024-05-10 8:42 ` Chen, Jiqian
2024-04-19 3:36 ` [RFC KERNEL PATCH v6 3/3] xen/privcmd: Add new syscall to get gsi from irq Jiqian Chen
2024-05-10 6:46 ` Jürgen Groß
2024-05-10 9:06 ` Chen, Jiqian
2024-05-10 9:53 ` Jürgen Groß
2024-05-10 10:13 ` Chen, Jiqian
2024-05-10 10:21 ` Jürgen Groß
2024-05-10 10:32 ` Chen, Jiqian
2024-05-10 11:27 ` Jürgen Groß
2024-05-11 2:16 ` Chen, Jiqian
2024-05-13 7:47 ` Chen, Jiqian
2024-05-13 7:59 ` Jürgen Groß
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ebdcc0b-3775-4c5e-9ffb-f45d048281dd@suse.com \
--to=jgross@suse.com \
--cc=Jiqian.Chen@amd.com \
--cc=Ray.Huang@amd.com \
--cc=bhelgaas@google.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).