From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Kuppuswamy Sathyanarayanan
<sathyanarayanan.kuppuswamy@linux.intel.com>
Cc: "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
Len Brown <lenb@kernel.org>
Subject: Re: [PATCH v2] ACPI: Move acpi_blacklisted() declaration to asm/acpi.h
Date: Tue, 30 Apr 2024 21:31:18 +0200 [thread overview]
Message-ID: <CAJZ5v0g7omX=OcObvEAs=ArpW9s+C8CvuW7Ew5EzQfuVDhpZjQ@mail.gmail.com> (raw)
In-Reply-To: <Zi9hFbrIfyDhrA5R@smile.fi.intel.com>
On Mon, Apr 29, 2024 at 10:58 AM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Sun, Apr 28, 2024 at 09:04:41PM -0700, Kuppuswamy Sathyanarayanan wrote:
> > The function acpi_blacklisted() is defined only when CONFIG_X86 is
> > enabled and is only used by X86 arch code. To align with its usage and
> > definition conditions, move its declaration to asm/acpi.h
>
> FWIW,
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
I have replaced the v1 that was applied some time ago with this one.
> ...
>
> > extern char acpi_video_backlight_string[];
> > extern long acpi_is_video_device(acpi_handle handle);
> > -extern int acpi_blacklisted(void);
>
> I would replace it with a blank line (to me it seems the above and below are
> different groups from semantic point of view, but Rafael may correct me).
And I have added the blank line as suggested.
> > extern void acpi_osi_setup(char *str);
> > extern bool acpi_osi_is_win8(void);
>
> --
Thanks!
prev parent reply other threads:[~2024-04-30 19:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-29 4:04 [PATCH v2] ACPI: Move acpi_blacklisted() declaration to asm/acpi.h Kuppuswamy Sathyanarayanan
2024-04-29 8:57 ` Andy Shevchenko
2024-04-30 19:31 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJZ5v0g7omX=OcObvEAs=ArpW9s+C8CvuW7Ew5EzQfuVDhpZjQ@mail.gmail.com' \
--to=rafael@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).