From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Dan Williams <dan.j.williams@intel.com>, Arnd Bergmann <arnd@kernel.org>
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Ben Cheatham <Benjamin.Cheatham@amd.com>,
Arnd Bergmann <arnd@arndb.de>, Len Brown <lenb@kernel.org>,
James Morse <james.morse@arm.com>,
Tony Luck <tony.luck@intel.com>, Borislav Petkov <bp@alien8.de>,
Avadhut Naik <Avadhut.Naik@amd.com>,
Shuai Xue <xueshuai@linux.alibaba.com>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] acpi: EINJ: mark remove callback as non-__exit
Date: Tue, 26 Mar 2024 12:18:33 +0100 [thread overview]
Message-ID: <CAJZ5v0iKbquyA8st=ywUd+WtcJ0A3FYDuhCqSq_3B_koi0RYXg@mail.gmail.com> (raw)
In-Reply-To: <CAJZ5v0ivpUuKGx9pW+QeQPSSXNWSSbJwN2oN9p_hmE-nV5VQKA@mail.gmail.com>
On Wed, Mar 20, 2024 at 9:00 PM Rafael J. Wysocki <rafael@kernel.org> wrote:
>
> On Wed, Mar 20, 2024 at 8:58 PM Dan Williams <dan.j.williams@intel.com> wrote:
> >
> > Arnd Bergmann wrote:
> > > From: Arnd Bergmann <arnd@arndb.de>
> > >
> > > The remove callback of a device is called whenever it is unbound,
> > > which may happen during runtime e.g. through sysfs, so this is not
> > > allowed to be dropped from the binary:
> > >
> > > WARNING: modpost: vmlinux: section mismatch in reference: einj_driver+0x8 (section: .data) -> einj_remove (section: .exit.text)
> > > ERROR: modpost: Section mismatches detected.
> > >
> > > Remove that annotation.
> >
> > Looks good, not sure why the build robots missed this while this was
> > sitting in -next. Yes, this was a side effect of reusing the former
> > einj_exit() as the device remove callback.
> >
> > Reviewed-by: Dan Williams <dan.j.williams@intel.com>
> >
> > Rafael, can you pick this up?
>
> I will, thanks!
Applied now, thanks!
prev parent reply other threads:[~2024-03-26 11:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-20 18:02 [PATCH] acpi: EINJ: mark remove callback as non-__exit Arnd Bergmann
2024-03-20 19:58 ` Dan Williams
2024-03-20 20:00 ` Rafael J. Wysocki
2024-03-26 11:18 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJZ5v0iKbquyA8st=ywUd+WtcJ0A3FYDuhCqSq_3B_koi0RYXg@mail.gmail.com' \
--to=rafael@kernel.org \
--cc=Avadhut.Naik@amd.com \
--cc=Benjamin.Cheatham@amd.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=bp@alien8.de \
--cc=dan.j.williams@intel.com \
--cc=james.morse@arm.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=xueshuai@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).