From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Guanbing Huang <albanhuang0@gmail.com>
Cc: gregkh@linuxfoundation.org, andriy.shevchenko@intel.com,
rafael.j.wysocki@intel.com, linux-acpi@vger.kernel.org,
tony@atomide.com, john.ogness@linutronix.de,
yangyicong@hisilicon.com, jirislaby@kernel.org,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
lvjianmin@loongson.cn, albanhuang@tencent.com,
tombinfan@tencent.com
Subject: Re: [PATCH v8 1/3] PNP: Add dev_is_pnp() macro
Date: Tue, 16 Apr 2024 21:05:42 +0200 [thread overview]
Message-ID: <CAJZ5v0ikW4o4g-yt5SnUFvKfLS6q1tGQ+3NTOfVPvwp7hZ3t2g@mail.gmail.com> (raw)
In-Reply-To: <4e68f5557ad53b671ca8103e572163eca52a8f29.1713234515.git.albanhuang@tencent.com>
On Tue, Apr 16, 2024 at 5:16 AM Guanbing Huang <albanhuang0@gmail.com> wrote:
>
> From: Guanbing Huang <albanhuang@tencent.com>
>
> Add dev_is_pnp() macro to determine whether the device is a PNP device.
>
> Signed-off-by: Guanbing Huang <albanhuang@tencent.com>
> Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> Reviewed-by: Bing Fan <tombinfan@tencent.com>
> Tested-by: Linheng Du <dylanlhdu@tencent.com>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
and please feel free to route it along with the rest of the series.
Thanks!
> ---
> v7 -> v8: delete a "Reviewed-by" tag, delete a "Reported-by" tag
> v6 -> v7: add a "Reviewed-by" tag and a "Reported-by" tag, fix build errors when CONFIG_PNP is not enabled
> v5 -> v6: fix the issue that the cover letter is not chained with the patch series
> v4 -> v5: change "pnp" in the commit message to uppercase
>
> include/linux/pnp.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/include/linux/pnp.h b/include/linux/pnp.h
> index ddbe7c3ca4ce..82561242cda4 100644
> --- a/include/linux/pnp.h
> +++ b/include/linux/pnp.h
> @@ -469,6 +469,8 @@ int compare_pnp_id(struct pnp_id *pos, const char *id);
> int pnp_register_driver(struct pnp_driver *drv);
> void pnp_unregister_driver(struct pnp_driver *drv);
>
> +#define dev_is_pnp(d) ((d)->bus == &pnp_bus_type)
> +
> #else
>
> /* device management */
> @@ -500,6 +502,8 @@ static inline int compare_pnp_id(struct pnp_id *pos, const char *id) { return -E
> static inline int pnp_register_driver(struct pnp_driver *drv) { return -ENODEV; }
> static inline void pnp_unregister_driver(struct pnp_driver *drv) { }
>
> +#define dev_is_pnp(d) false
> +
> #endif /* CONFIG_PNP */
>
> /**
> --
next prev parent reply other threads:[~2024-04-16 19:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-16 3:15 [PATCH v8 0/3] serial: 8250_pnp: Support configurable reg shift property Guanbing Huang
2024-04-16 3:16 ` [PATCH v8 1/3] PNP: Add dev_is_pnp() macro Guanbing Huang
2024-04-16 13:51 ` Andy Shevchenko
2024-04-16 19:05 ` Rafael J. Wysocki [this message]
2024-04-16 3:16 ` [PATCH v8 2/3] serial: port: Add support of PNP IRQ to __uart_read_properties() Guanbing Huang
2024-04-16 3:16 ` [PATCH v8 3/3] serial: 8250_pnp: Support configurable reg shift property Guanbing Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJZ5v0ikW4o4g-yt5SnUFvKfLS6q1tGQ+3NTOfVPvwp7hZ3t2g@mail.gmail.com \
--to=rafael@kernel.org \
--cc=albanhuang0@gmail.com \
--cc=albanhuang@tencent.com \
--cc=andriy.shevchenko@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lvjianmin@loongson.cn \
--cc=rafael.j.wysocki@intel.com \
--cc=tombinfan@tencent.com \
--cc=tony@atomide.com \
--cc=yangyicong@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).