From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Manfred Spraul <manfred@colorfullife.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Zhang Rui <rui.zhang@intel.com>, Len Brown <lenb@kernel.org>,
1vier1@web.de
Subject: Re: drivers/acpi/processor_thermal.c: avoid cpufreq_get_policy()
Date: Thu, 30 Dec 2021 17:23:13 +0100 [thread overview]
Message-ID: <CAJZ5v0jJr=-O0UdXKj=nHtDv5oJwKWd_5het80QJZ5PBmzitPw@mail.gmail.com> (raw)
In-Reply-To: <20211222191411.13805-1-manfred@colorfullife.com>
On Wed, Dec 22, 2021 at 8:14 PM Manfred Spraul <manfred@colorfullife.com> wrote:
>
> cpu_has_cpufreq() stores a 'struct cpufreq_policy' on the stack.
> Unfortunately, with debugging options enabled, the structure can be
> larger than 1024 bytes, which causes a compiler warning/error.
>
> (actually observed: 1184 bytes).
>
> Therefore: Switch to cpufreq_cpu_get().
>
> Signed-off-by: Manfred Spraul <manfred@colorfullife.com>
>
> ---
> drivers/acpi/processor_thermal.c | 15 ++++++++++++---
> 1 file changed, 12 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/acpi/processor_thermal.c b/drivers/acpi/processor_thermal.c
> index a3d34e3f9f94..74210d63f62c 100644
> --- a/drivers/acpi/processor_thermal.c
> +++ b/drivers/acpi/processor_thermal.c
> @@ -53,10 +53,19 @@ static int phys_package_first_cpu(int cpu)
>
> static int cpu_has_cpufreq(unsigned int cpu)
> {
> - struct cpufreq_policy policy;
> - if (!acpi_processor_cpufreq_init || cpufreq_get_policy(&policy, cpu))
> + struct cpufreq_policy *policy;
> + int retval;
Why is this needed?
> +
> + if (!acpi_processor_cpufreq_init)
> return 0;
> - return 1;
> +
> + retval = 0;
> + policy = cpufreq_cpu_get(cpu);
> + if (policy) {
> + cpufreq_cpu_put(policy);
return 1;
> + retval = 1;
> + }
> + return retval;
return 0;
> }
>
> static int cpufreq_get_max_state(unsigned int cpu)
> --
> 2.33.1
>
next prev parent reply other threads:[~2021-12-30 16:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-22 19:14 drivers/acpi/processor_thermal.c: avoid cpufreq_get_policy() Manfred Spraul
2021-12-30 16:23 ` Rafael J. Wysocki [this message]
2021-12-30 16:47 ` Manfred Spraul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJZ5v0jJr=-O0UdXKj=nHtDv5oJwKWd_5het80QJZ5PBmzitPw@mail.gmail.com' \
--to=rafael@kernel.org \
--cc=1vier1@web.de \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).