From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
Kent Gibson <warthog618@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Arend van Spriel <arend.vanspriel@broadcom.com>,
Kalle Valo <kvalo@kernel.org>,
Charles Keepax <ckeepax@opensource.cirrus.com>
Subject: Re: [PATCH v2 1/2] gpiolib: Fix a mess with the GPIO_* flags
Date: Tue, 9 Apr 2024 14:55:20 +0200 [thread overview]
Message-ID: <CAMRc=Meh6K2zxpVPHvsDcr5vMMeagK7FGhnUPz3bb2rQQCPHJA@mail.gmail.com> (raw)
In-Reply-To: <ZhU5uDJk_M_TtKH2@smile.fi.intel.com>
On Tue, Apr 9, 2024 at 2:51 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Tue, Apr 09, 2024 at 11:42:37AM +0200, Bartosz Golaszewski wrote:
> > On Tue, Apr 9, 2024 at 1:17 AM Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
> > >
> > > The GPIO_* flag definitions are *almost* duplicated in two files
> > > (with unmatches OPEN_SOURCE / OPEN_DRAIN). Moreover, some code relies
> > > on one set of definitions while the rest is on the other. Clean up
> > > this mess by providing only one source of the definitions to all.
> > >
> > > Fixes: b424808115cb ("brcm80211: brcmsmac: Move LEDs to GPIO descriptors")
> > > Fixes: 5923ea6c2ce6 ("gpio: pass lookup and descriptor flags to request_own")
> > > Fixes: fed7026adc7c ("gpiolib: Make use of enum gpio_lookup_flags consistent")
> > > Fixes: 4c0facddb7d8 ("gpio: core: Decouple open drain/source flag with active low/high")
> > > Fixes: 69d301fdd196 ("gpio: add DT bindings for existing consumer flags")
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > ---
> > > drivers/gpio/gpiolib-of.c | 5 ++---
> > > drivers/gpio/gpiolib.c | 8 +++-----
> > > .../broadcom/brcm80211/brcmsmac/led.c | 2 +-
> > > include/linux/gpio/driver.h | 3 +--
> > > include/linux/gpio/machine.h | 20 +++++--------------
> > > 5 files changed, 12 insertions(+), 26 deletions(-)
> >
> > I don't think ./dt-bindings/gpio/gpio.h is the right source of these
> > defines for everyone - including non-OF systems. I would prefer the
> > ones in include/linux/gpio/machine.h be the upstream source but then
> > headers in include/dt-bindings/ cannot include them so my second-best
> > suggestion is to rename the ones in include/linux/gpio/machine.h and
> > treewide too. In general values from ./dt-bindings/gpio/gpio.h should
> > only be used in DTS sources and gpiolib-of code.
>
> Then, please fix that your way. It's quite annoying issue.
>
This is not difficult in itself but it's a tree-wide change so we will
probably have to send it to Torvalds at the end of the merge window in
a separate pull-request.
I don't really have time now, I'll be travelling for 5 weeks in a row.
I'll see closer to the merge window. Or next release cycle.
Bart
next prev parent reply other threads:[~2024-04-09 12:55 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-08 23:12 [PATCH v2 0/2] gpiolib: Fix gpio_lookup_flags mess and add Return sections Andy Shevchenko
2024-04-08 23:12 ` [PATCH v2 1/2] gpiolib: Fix a mess with the GPIO_* flags Andy Shevchenko
2024-04-09 4:38 ` kernel test robot
2024-04-09 8:12 ` kernel test robot
2024-04-09 9:42 ` Bartosz Golaszewski
2024-04-09 12:51 ` Andy Shevchenko
2024-04-09 12:55 ` Bartosz Golaszewski [this message]
2024-04-09 13:30 ` Andy Shevchenko
2024-04-12 8:20 ` Linus Walleij
2024-04-12 15:25 ` Andy Shevchenko
2024-04-12 19:43 ` Bartosz Golaszewski
2024-04-16 12:22 ` Linus Walleij
2024-04-16 14:05 ` Andy Shevchenko
2024-04-16 21:07 ` Bartosz Golaszewski
2024-04-17 8:45 ` Andy Shevchenko
2024-04-17 18:39 ` Bartosz Golaszewski
2024-04-18 11:52 ` Andy Shevchenko
2024-04-19 13:29 ` Linus Walleij
2024-04-19 13:38 ` Andy Shevchenko
2024-04-08 23:12 ` [PATCH v2 2/2] gpiolib: Update the kernel documentation - add Return sections Andy Shevchenko
2024-04-09 12:51 ` Andy Shevchenko
2024-04-09 14:01 ` Bartosz Golaszewski
2024-04-09 14:06 ` Andy Shevchenko
2024-04-09 14:18 ` Bartosz Golaszewski
2024-04-09 14:29 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMRc=Meh6K2zxpVPHvsDcr5vMMeagK7FGhnUPz3bb2rQQCPHJA@mail.gmail.com' \
--to=brgl@bgdev.pl \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arend.vanspriel@broadcom.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211@lists.linux.dev \
--cc=ckeepax@opensource.cirrus.com \
--cc=kvalo@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).