Linux-ACPI Archive mirror
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Cc: "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
	Len Brown <lenb@kernel.org>
Subject: Re: [PATCH v1] ACPI: Declare acpi_blacklisted() only if CONFIG_X86 is enabled
Date: Mon, 8 Apr 2024 18:53:14 +0300	[thread overview]
Message-ID: <ZhQS6uYmpsxFD3gn@smile.fi.intel.com> (raw)
In-Reply-To: <CAC41dw-Df3L7B=Tq2QkQHDT2Yf3MzHgy8-czPAkZhdPf0Tea4Q@mail.gmail.com>

On Mon, Apr 08, 2024 at 08:42:48AM -0700, Kuppuswamy Sathyanarayanan wrote:
> On Mon, Apr 8, 2024 at 7:53 AM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Sat, Apr 06, 2024 at 11:33:41PM -0700, Kuppuswamy Sathyanarayanan wrote:

...

> > >  extern char acpi_video_backlight_string[];
> > >  extern long acpi_is_video_device(acpi_handle handle);
> > > +#ifdef CONFIG_X86
> > >  extern int acpi_blacklisted(void);
> > > +#endif
> > >  extern void acpi_osi_setup(char *str);
> > >  extern bool acpi_osi_is_win8(void);
> >
> > IIRC there is already similar ifdeffery, can we just move the declaration
> > there?
> 
> There is none for CONFIG_X86. We only have some combinations or
> derived config checks like below:
> 
> #if defined(CONFIG_X86) || defined(CONFIG_LOONGARCH)
> #ifdef CONFIG_X86_IO_APIC

Okay, it seems I mixed this with acpi_bus.h.

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2024-04-08 15:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-07  6:33 [PATCH v1] ACPI: Declare acpi_blacklisted() only if CONFIG_X86 is enabled Kuppuswamy Sathyanarayanan
2024-04-08 14:53 ` Andy Shevchenko
2024-04-08 15:42   ` Kuppuswamy Sathyanarayanan
2024-04-08 15:53     ` Andy Shevchenko [this message]
2024-04-22 16:37 ` Rafael J. Wysocki
2024-04-23 13:02   ` Andy Shevchenko
2024-04-29  4:06     ` Kuppuswamy Sathyanarayanan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZhQS6uYmpsxFD3gn@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael.j.wysocki@intel.com \
    --cc=sathyanarayanan.kuppuswamy@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).