From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Guanbing Huang <albanhuang0@gmail.com>
Cc: gregkh@linuxfoundation.org, rafael.j.wysocki@intel.com,
linux-acpi@vger.kernel.org, tony@atomide.com,
john.ogness@linutronix.de, yangyicong@hisilicon.com,
jirislaby@kernel.org, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org, lvjianmin@loongson.cn,
albanhuang@tencent.com, tombinfan@tencent.com
Subject: Re: [PATCH v7 1/3] PNP: Add dev_is_pnp() macro
Date: Fri, 12 Apr 2024 18:52:24 +0300 [thread overview]
Message-ID: <ZhlYuPZTrhwZl0HD@smile.fi.intel.com> (raw)
In-Reply-To: <ZhlTdPNuD_IayWlw@smile.fi.intel.com>
On Fri, Apr 12, 2024 at 06:29:56PM +0300, Andy Shevchenko wrote:
> On Fri, Apr 12, 2024 at 11:24:12AM +0800, Guanbing Huang wrote:
...
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> I haven't given this tag _explicitly_ as it's a new code and I answered in
> the previous email that I will give one for the new version.
>
> ...
>
> > Reported-by: kernel test robot <lkp@intel.com>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202404100523.b06UvPSB-lkp@intel.com/
>
> No, the new feature can't be reported.
>
> ...
>
> Please, try again.
To clarify, remove the above lines from your first commit.
If you want, you may leave my Rb tags in the patches 2 & 3
as code wasn't changed there.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-04-12 15:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 3:23 [PATCH v7 0/3] serial: 8250_pnp: Support configurable reg shift property Guanbing Huang
2024-04-12 3:24 ` [PATCH v7 1/3] PNP: Add dev_is_pnp() macro Guanbing Huang
2024-04-12 15:29 ` Andy Shevchenko
2024-04-12 15:52 ` Andy Shevchenko [this message]
2024-04-12 3:24 ` [PATCH v7 2/3] serial: port: Add support of PNP IRQ to __uart_read_properties() Guanbing Huang
2024-04-12 3:24 ` [PATCH v7 3/3] serial: 8250_pnp: Support configurable reg shift property Guanbing Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZhlYuPZTrhwZl0HD@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=albanhuang0@gmail.com \
--cc=albanhuang@tencent.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lvjianmin@loongson.cn \
--cc=rafael.j.wysocki@intel.com \
--cc=tombinfan@tencent.com \
--cc=tony@atomide.com \
--cc=yangyicong@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).