Linux-ACPI Archive mirror
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Javier Carrasco <javier.carrasco@wolfvision.net>,
	Jonathan Cameron <jic23@kernel.org>
Cc: Daniel Scally <djrscally@gmail.com>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] device property: introduce fwnode_for_each_child_node_scoped()
Date: Thu, 2 May 2024 21:04:35 +0300	[thread overview]
Message-ID: <ZjPVs5NJzlMzHYn0@smile.fi.intel.com> (raw)
In-Reply-To: <ZjPVXW9tr0RLp7Jn@smile.fi.intel.com>

On Thu, May 02, 2024 at 09:03:09PM +0300, Andy Shevchenko wrote:
> On Thu, May 02, 2024 at 07:58:26PM +0200, Javier Carrasco wrote:
> > On 5/2/24 17:34, Andy Shevchenko wrote:
> > > On Thu, May 02, 2024 at 12:55:40PM +0200, Javier Carrasco wrote:

...

> > >> This macro has been tested with a patch series that has not been
> > >> applied yet and is under discussion in input [1], which makes use of the
> > >> non-scoped version of the loop.
> > > 
> > > So, why should we apply a dead code?
> > 
> > I will add this patch to the series I mentioned, so there is a first use
> > case.
> 
> Sounds like a good plan.

Ah, note that IIO has already some patches against device property APIs. Maybe
it's already done by Jonathan.
Cc'ed to him.

> > Even if the _available variant is preferred, the other one is more
> > widely used, and having a scoped version will allow for safer code.

-- 
With Best Regards,
Andy Shevchenko



      reply	other threads:[~2024-05-02 18:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-02 10:55 [PATCH] device property: introduce fwnode_for_each_child_node_scoped() Javier Carrasco
2024-05-02 15:34 ` Andy Shevchenko
2024-05-02 17:58   ` Javier Carrasco
2024-05-02 18:03     ` Andy Shevchenko
2024-05-02 18:04       ` Andy Shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZjPVs5NJzlMzHYn0@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=djrscally@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=javier.carrasco@wolfvision.net \
    --cc=jic23@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).