From: Guenter Roeck <linux@roeck-us.net>
To: Armin Wolf <W_Armin@gmx.de>
Cc: Mikael Lund Jepsen <mlj@danelec.com>,
"rafael.j.wysocki@intel.com" <rafael.j.wysocki@intel.com>,
"lenb@kernel.org" <lenb@kernel.org>,
"jdelvare@suse.com" <jdelvare@suse.com>,
"linux@weissschuh.net" <linux@weissschuh.net>,
"ilpo.jarvinen@linux.intel.com" <ilpo.jarvinen@linux.intel.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>
Subject: Re: [PATCH v2] ACPI: fan: Add hwmon support
Date: Thu, 11 Apr 2024 17:57:25 -0700 [thread overview]
Message-ID: <e5398618-5140-4553-8dab-6f5ad73de805@roeck-us.net> (raw)
In-Reply-To: <b0899d74-79d7-459c-8f2d-17a17a0f58d7@gmx.de>
On Fri, Apr 12, 2024 at 01:38:11AM +0200, Armin Wolf wrote:
[ .. ]
> I just noticed that the drvdata argument of the is_visible callback is marked as const, so i cannot use dev_get_drvdata() on the resulting ACPI device.
> Guenter, would it be ok to make drvdata non-const in a separate patch series?
>
I don't know what you are trying to do (the is_visible callback
isn't supposed to change the information passed to it), but not
really.
Guenter
prev parent reply other threads:[~2024-04-12 0:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-09 21:33 [PATCH v2] ACPI: fan: Add hwmon support Armin Wolf
2024-04-10 14:29 ` Mikael Lund Jepsen
2024-04-11 20:30 ` Armin Wolf
2024-04-11 23:38 ` Armin Wolf
2024-04-12 0:57 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5398618-5140-4553-8dab-6f5ad73de805@roeck-us.net \
--to=linux@roeck-us.net \
--cc=W_Armin@gmx.de \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jdelvare@suse.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=mlj@danelec.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).